Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line additions and deletions params #1023

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

alanhamlett
Copy link
Member

New optional params:

  • --line-additions 123
  • --line-deletions 123

Closes #609.

cmd/params/params_test.go Outdated Show resolved Hide resolved
@alanhamlett alanhamlett force-pushed the feature/line-additions-deletions branch from 32d0506 to cc360c9 Compare January 24, 2024 23:10
@alanhamlett alanhamlett force-pushed the feature/line-additions-deletions branch 2 times, most recently from 98390e9 to dd085fd Compare January 24, 2024 23:32
@alanhamlett alanhamlett force-pushed the feature/line-additions-deletions branch from dd085fd to b7031e7 Compare January 25, 2024 07:57
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7ec63d7) 62.96% compared to head (b7031e7) 62.98%.

@@             Coverage Diff             @@
##           develop    #1023      +/-   ##
===========================================
+ Coverage    62.96%   62.98%   +0.01%     
===========================================
  Files          374      374              
  Lines        15965    15994      +29     
===========================================
+ Hits         10053    10074      +21     
- Misses        5378     5384       +6     
- Partials       534      536       +2     
Flag Coverage Δ
unittests 62.98% <74.19%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/heartbeat/heartbeat.go 76.27% <100.00%> (+0.44%) ⬆️
pkg/heartbeat/heartbeat.go 88.37% <100.00%> (+0.27%) ⬆️
cmd/root.go 0.00% <0.00%> (ø)
cmd/params/params.go 85.56% <73.91%> (-0.40%) ⬇️

Copy link
Member

@gandarez gandarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alanhamlett alanhamlett merged commit a675bbc into develop Jan 25, 2024
21 checks passed
@alanhamlett alanhamlett deleted the feature/line-additions-deletions branch January 25, 2024 21:45
This was referenced Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Track Lines of Code
2 participants