Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change enrtree public key to pattern #278

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix: change enrtree public key to pattern #278

merged 2 commits into from
Oct 12, 2023

Conversation

yakimant
Copy link
Member

@yakimant yakimant commented Oct 5, 2023 •
edited
Loading

@yakimant yakimant requested a review from a team as a code owner October 5, 2023 10:39
@yakimant yakimant mentioned this pull request Oct 5, 2023
Merged
fryorcraken
fryorcraken reviewed Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@fryorcraken fryorcraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You then need to add it to the ignore regexp list so it's being ignored by spell check

examples/web-chat/.cspell.json Outdated Show resolved Hide resolved
@yakimant
Copy link
Member Author

I've run prettier locally (unfortunately --list-different on CI doesn't show the problematic code.

And problem appeared to be in the pattern. I've fixed the complaing, but I don't know how to test that pattern works.

@fryorcraken, @danisharora099, please help to test it.

@fryorcraken fryorcraken merged commit 736f320 into master Oct 12, 2023
9 checks passed
@fryorcraken fryorcraken deleted the changre_enrtree_public_key_to_pattern branch October 12, 2023 04:34
@danisharora099
Copy link
Contributor

I've run prettier locally (unfortunately --list-different on CI doesn't show the problematic code.

And problem appeared to be in the pattern. I've fixed the complaing, but I don't know how to test that pattern works.

@fryorcraken, @danisharora099, please help to test it.

Sorry, what's the problem here?

@fryorcraken
Copy link
Collaborator

I've run prettier locally (unfortunately --list-different on CI doesn't show the problematic code.

And problem appeared to be in the pattern. I've fixed the complaing, but I don't know how to test that pattern works.

@fryorcraken, @danisharora099, please help to test it.

Sorry, what's the problem here?

I don't think there was an issue. Sorted 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fryorcraken fryorcraken Awaiting requested review from fryorcraken

@danisharora099 danisharora099 Awaiting requested review from danisharora099

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yakimant @danisharora099 @fryorcraken