-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: filter/v2/subscriptions take a lot of time and even timeout sometimes #972
Comments
Going through the logs i have following observations:
I find it odd that discovery takes close to 20 seconds in a test setup. Because i see peers immediately getting identified and getting added.
Few ways this can be mitigated in test env is :
Would be good if you can share what is your test setup for this test. |
I do use the filternode flag when starting the filter node. I've dug a little deeper and it would seem that this issue happens for the 1st requests after starting the nodes (notice in the test logs bellow that the
|
We don't have a similar page, but the yaml file for this can be found at https://github.com/waku-org/go-waku/blob/master/cmd/waku/server/rest/admin_api.yaml. You can refer to the details expected in request and response. You can import this file into postman to get sample req/resp structures |
I am not talking about From the logs i don't see --filternode flag being specified, which is why i am guessing discovery could be causing the delay. Will go through the logs in detail to analyze what might be happening. In the meantime it would be helpful to know your test setup for this case. |
the 2nd node is using |
Regarding the test setup it should be all in those logs.
Then a 10 sec propagation sleep:
|
Ah..somehow i missed it. Thanks |
Can you rerun this by subscribing the nodes to pubsubTopic Just wanted to eliminate 1 more variable to narrow down scope of the potential issue. |
I tried to test this but there's a regression that blocks go-waku tests: #988 |
Weekly Update
|
I tried starting the Relay node with pubsubTopic |
Does it timeout? If so that means the other node is not supporting that shard. Otherwise discovery should happen and it should still work. Can you confirm? |
Yes, the first |
That is interesting, do share logs where first request times-out for both the nodes. |
nodes.zip |
To Reproduce
filter/v2/subscriptions
with a payload like{"requestId": "c712e7f5-a536-4228-8ecc-de395d8b429f", "contentFilters": ["/test/1/waku-filter/proto"], "pubsubTopic": "/waku/2/rs/0/1"}
Actual behavior
Usually this takes ~10 seconds but many times it happens to go beyond 20 and eventually time out (because of the test timeout) and fail the test
go-waku version/commit hash
harbor.status.im/wakuorg/go-waku:lates
tAdditional context
Added some logs when this request took a long time
timeout_after_20_seconds.log
took_22_seconds.log
The text was updated successfully, but these errors were encountered: