Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple node tests #8

Merged
merged 15 commits into from
Dec 27, 2023
Merged

multiple node tests #8

merged 15 commits into from
Dec 27, 2023

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Dec 19, 2023 •
edited

  • Added filter multiple nodes and idle subscription tests(with multiple nodes)
  • Added support for asserting nwaku metrics
  • Multiple fixes and adjustments based on the latest fixes in nwaku and go-waku
  • reached 95 tests

Issues reported:

@fbarbu15 fbarbu15 changed the title mulitple node tests multiple node tests Dec 22, 2023
@fbarbu15 fbarbu15 marked this pull request as ready for review December 22, 2023 16:47
AlejandroCabeza
AlejandroCabeza approved these changes Dec 25, 2023
View reviewed changes
Copy link

@AlejandroCabeza AlejandroCabeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/node/api_clients/rest.py Show resolved Hide resolved
src/node/waku_node.py Outdated Show resolved Hide resolved
src/steps/filter.py Show resolved Hide resolved
src/steps/filter.py Outdated Show resolved Hide resolved
tests/filter/test_unsubscribe_all.py Outdated Show resolved Hide resolved
romanzac
romanzac approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@romanzac romanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Interesting to know we have a Harbor registry available in Status.

@fbarbu15 fbarbu15 merged commit d7be7e9 into master Dec 27, 2023
1 of 2 checks passed
@fbarbu15 fbarbu15 deleted the tests/filter-multiple-nodes branch December 27, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroCabeza AlejandroCabeza AlejandroCabeza approved these changes

@romanzac romanzac romanzac approved these changes

@AlbertoSoutullo AlbertoSoutullo Awaiting requested review from AlbertoSoutullo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbarbu15 @AlejandroCabeza @romanzac