ci: fix GOPATH, PATH, and GOCACHE #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
jakubgs
force-pushed
the
ci/fix-tests-gopath
branch
from
d33f7aa
to
2759a99
Compare
|
What the FUCK is happening?
This PR is #512, why is it trying to get files form other PR builds? |
jakubgs
force-pushed
the
ci/fix-tests-gopath
branch
from
2759a99
to
25a81cf
Compare
|
I believe this is caused by things cached in We can customize it using |
|
Oh, there is another cache in place here: |
jakubgs
force-pushed
the
ci/fix-tests-gopath
branch
2 times, most recently
from
a27119f
to
9a94358
Compare
richard-ramos
approved these changes
Apr 14, 2023
Using `$HOME/go` is bad and you should feel bad. Also, adding `/usr/loca/go/bin` is a terrible idea. And `GOCACHE` is poisoning stuff for linter. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
ci/fix-tests-gopath
branch
from
9a94358
to
fd5865b
Compare
jakubgs
changed the title
jakubgs
added a commit
to logos-co/nomos-node
that referenced
this pull request
Apr 26, 2023
We've had this issue before with some `go-waku` builds: waku-org/go-waku#512 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to logos-co/nomos-node
that referenced
this pull request
Apr 26, 2023
We've had this issue before with some `go-waku` builds: waku-org/go-waku#512 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to logos-co/nomos-node
that referenced
this pull request
Apr 26, 2023
We've had this issue before with some `go-waku` builds: waku-org/go-waku#512 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to logos-co/nomos-node
that referenced
this pull request
Jun 12, 2023
We've had this issue before with some `go-waku` builds: waku-org/go-waku#512 Signed-off-by: Jakub Sokołowski <jakub@status.im>
bacv
pushed a commit
to logos-co/nomos-node
that referenced
this pull request
Jun 13, 2023
We've had this issue before with some `go-waku` builds: waku-org/go-waku#512 Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
$HOME/gois bad and you should feel bad.Also, adding
/usr/loca/go/binis a terrible idea.And
GOCACHEis poisoning stuff for linter.