Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CommonService): add channel and use commonService in discv5 #735

Merged
merged 3 commits into from
Sep 18, 2023
Merged

feat(CommonService): add channel and use commonService in discv5 #735

merged 3 commits into from
Sep 18, 2023

Conversation

harsh-98
Copy link
Contributor

Description

Add commonService to discv5.

Changes

  • Add channel to CommonService. This channel is closed after all the running goRoutine in the service have ended. Ensuring no panics.

Tests

  • All test passed.

@status-im-auto
Copy link

status-im-auto commented Sep 14, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (36)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c5c61a2 #1 2023-09-14 06:38:21 ~2 min nix-flake 📄log
✔️ c5c61a2 #1 2023-09-14 06:38:41 ~2 min linux 📦deb
✔️ c5c61a2 #1 2023-09-14 06:39:15 ~2 min tests 📄log
✔️ c5c61a2 #1 2023-09-14 06:39:33 ~3 min tests 📄log
✔️ c5c61a2 #1 2023-09-14 06:40:16 ~3 min android 📦tgz
✔️ c5c61a2 #1 2023-09-14 06:40:30 ~4 min ios 📦tgz
✖️ dd7b968 #2 2023-09-14 10:18:50 ~23 sec tests 📄log
✔️ dd7b968 #2 2023-09-14 10:19:20 ~56 sec linux 📦deb
✖️ dd7b968 #2 2023-09-14 10:19:48 ~1 min tests 📄log
✔️ dd7b968 #2 2023-09-14 10:20:16 ~1 min nix-flake 📄log
✔️ dd7b968 #2 2023-09-14 10:21:48 ~3 min android 📦tgz
✔️ dd7b968 #2 2023-09-14 10:23:06 ~4 min ios 📦tgz
✔️ 020ab99 #3 2023-09-14 10:22:51 ~55 sec linux 📦deb
✔️ 020ab99 #3 2023-09-14 10:23:49 ~1 min nix-flake 📄log
✔️ 020ab99 #3 2023-09-14 10:24:48 ~2 min tests 📄log
✔️ 020ab99 #3 2023-09-14 10:24:54 ~2 min tests 📄log
✔️ 020ab99 #3 2023-09-14 10:24:54 ~3 min android 📦tgz
✔️ 020ab99 #3 2023-09-14 10:25:50 ~3 min ios 📦tgz
✖️ 59cb573 #4 2023-09-18 03:23:55 ~17 sec nix-flake 📄log
❌ 59cb573 #4 2023-09-18 03:24:14 ~36 sec ios 📄log
✔️ 59cb573 #4 2023-09-18 03:25:31 ~1 min tests 📄log
✔️ 59cb573 #4 2023-09-18 03:25:41 ~2 min linux 📦deb
✔️ 59cb573 #4 2023-09-18 03:26:31 ~2 min tests 📄log
✔️ 59cb573 #4 2023-09-18 03:27:43 ~4 min android 📦tgz
✖️ 585be02 #5 2023-09-18 03:25:03 ~15 sec nix-flake 📄log
❌ 585be02 #5 2023-09-18 03:25:12 ~24 sec ios 📄log
❌ 585be02 #5 2023-09-18 03:26:03 ~18 sec linux 📄log
✖️ 585be02 #5 2023-09-18 03:26:55 ~1 min tests 📄log
✖️ 585be02 #5 2023-09-18 03:27:55 ~1 min tests 📄log
❌ 585be02 #5 2023-09-18 03:30:17 ~2 min android 📄log
✖️ 0b52297 #6 2023-09-18 03:30:48 ~15 sec nix-flake 📄log
❌ 0b52297 #6 2023-09-18 03:30:48 ~17 sec linux 📄log
❌ 0b52297 #6 2023-09-18 03:30:55 ~24 sec ios 📄log
✖️ 0b52297 #6 2023-09-18 03:31:14 ~39 sec tests 📄log
✖️ 0b52297 #6 2023-09-18 03:31:14 ~40 sec tests 📄log
❌ 0b52297 #6 2023-09-18 03:32:24 ~1 min android 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ cafb0f0 #7 2023-09-18 03:33:59 ~16 sec nix-flake 📄log
❌ cafb0f0 #7 2023-09-18 03:34:07 ~24 sec ios 📄log
✔️ cafb0f0 #7 2023-09-18 03:34:46 ~1 min linux 📦deb
✔️ cafb0f0 #7 2023-09-18 03:35:08 ~1 min tests 📄log
❌ cafb0f0 #8 2023-09-18 03:35:23 ~15 sec ios 📄log
✔️ cafb0f0 #7 2023-09-18 03:35:55 ~2 min tests 📄log
✔️ cafb0f0 #7 2023-09-18 03:37:25 ~3 min android 📦tgz
❌ cafb0f0 #9 2023-09-18 03:37:34 ~14 sec ios 📄log
❌ cafb0f0 #10 2023-09-18 06:16:28 ~17 sec ios 📄log
✔️ cafb0f0 #9 2023-09-18 07:44:45 ~59 sec linux 📦deb
✔️ cafb0f0 #9 2023-09-18 07:45:23 ~1 min tests 📄log
✔️ cafb0f0 #9 2023-09-18 07:45:54 ~1 min tests 📄log
✔️ cafb0f0 #9 2023-09-18 07:46:07 ~1 min nix-flake 📄log
✔️ cafb0f0 #12 2023-09-18 07:46:26 ~3 min ios 📦tgz
✔️ cafb0f0 #9 2023-09-18 07:48:43 ~3 min android 📦tgz
✔️ 089cfd3 #8 2023-09-18 07:43:41 ~1 min linux 📦deb
✔️ 089cfd3 #8 2023-09-18 07:43:57 ~1 min tests 📄log
✔️ 089cfd3 #8 2023-09-18 07:44:04 ~1 min tests 📄log
✔️ 089cfd3 #8 2023-09-18 07:44:12 ~2 min nix-flake 📄log
✔️ 089cfd3 #8 2023-09-18 07:45:35 ~3 min android 📦tgz
✔️ 089cfd3 #11 2023-09-18 07:46:11 ~4 min ios 📦tgz

@harsh-98 harsh-98 marked this pull request as ready for review September 14, 2023 06:42
@harsh-98
Copy link
Contributor Author

Really proud that this PR fixed 18 codeClimate issues. @richard-ramos how did you fix failing codeClimate due to generic syntax.

chaitanyaprem
chaitanyaprem reviewed Sep 14, 2023
View reviewed changes
waku/v2/protocol/common_service.go Outdated Show resolved Hide resolved
waku/v2/protocol/common_service.go Outdated Show resolved Hide resolved
waku/v2/discv5/discover.go Outdated Show resolved Hide resolved
waku/v2/discv5/discover.go Show resolved Hide resolved
@richard-ramos
Copy link
Member

@richard-ramos how did you fix failing codeClimate due to generic syntax.

I disabled golint ;) https://github.com/waku-org/go-waku/blob/master/.codeclimate.yml#L2-L3

@chaitanyaprem chaitanyaprem mentioned this pull request Sep 15, 2023
Merged
@harsh-98 harsh-98 force-pushed the Discv5CommonService branch 2 times, most recently from 089cfd3 to cafb0f0 Compare September 18, 2023 07:42
chaitanyaprem
chaitanyaprem approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do address minor comments.

waku/v2/peerstore/waku_peer_store.go Show resolved Hide resolved
waku/v2/rendezvous/rendezvous.go Show resolved Hide resolved
@harsh-98 harsh-98 merged commit a5f9ee5 into master Sep 18, 2023
11 of 12 checks passed
@harsh-98 harsh-98 deleted the Discv5CommonService branch September 18, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harsh-98 @status-im-auto @richard-ramos @chaitanyaprem