fix: nix build with RLN #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
richard-ramos
force-pushed
the
fix/nix/rln
branch
2 times, most recently
from
5dae32d
to
c983f3a
Compare
richard-ramos
force-pushed
the
fix/nix/rln
branch
from
c983f3a
to
39e08d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
buildGo119Moduleusesgo mod vendor. Looking at how this command works, I noticed that it only downloads the files that are inside packages referenced in the code. The linking for RLN is not referenced as a package but via cgo. To solve this, I added some dummy files in go-zerokit-rln x86_64, arm and apple, and references to this file to forcego mod vendorto download the static librariesIssue
closes #731