Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: force reachability #778

Merged
merged 3 commits into from
Sep 28, 2023
Merged

feat: force reachability #778

merged 3 commits into from
Sep 28, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Sep 27, 2023

Description

Replaces the --unreachable flag by --reachability which accepts the values public or private to force circuit relay to work locally.

i.e.:

node1 (circuit relay server)

./build/waku --reachability=public --circuit-relay --p=55344 --nodekey=1122334455667788990011223344556677889900112233445566778899001122

node2 (unreachable node)

./build/waku --reachability=private --staticnode=/ip4/192.168.0.1/tcp/55344/p2p/16Uiu2HAmMGhfSTUzKbsjMWxc6T1X4wiTWSF1bEWSLjAukCm7KiHV -p=0

After a while, node2 should receive a circuit relay addr from node1

@status-im-auto
Copy link

status-im-auto commented Sep 27, 2023

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 031cd56 #1 2023-09-27 03:33:29 ~2 min nix-flake 📄log
✔️ 031cd56 #1 2023-09-27 03:33:44 ~2 min linux 📦deb
✔️ 031cd56 #1 2023-09-27 03:34:29 ~3 min tests 📄log
✔️ 031cd56 #1 2023-09-27 03:34:33 ~3 min tests 📄log
✔️ 031cd56 #1 2023-09-27 03:35:34 ~4 min android 📦tgz
✔️ 031cd56 #1 2023-09-27 03:36:29 ~5 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
200b854 #2 2023-09-27 15:05:16 ~49 sec ios 📄log
✔️ 200b854 #2 2023-09-27 15:06:23 ~1 min nix-flake 📄log
✔️ 200b854 #2 2023-09-27 15:06:35 ~2 min tests 📄log
✔️ 200b854 #2 2023-09-27 15:07:04 ~2 min linux 📦deb
✔️ 200b854 #2 2023-09-27 15:07:41 ~3 min tests 📄log
✔️ 200b854 #2 2023-09-27 15:07:51 ~3 min android 📦tgz
✔️ accd406 #3 2023-09-28 19:41:11 ~1 min linux 📦deb
✔️ accd406 #3 2023-09-28 19:41:36 ~1 min tests 📄log
✔️ accd406 #3 2023-09-28 19:42:01 ~1 min nix-flake 📄log
✔️ accd406 #3 2023-09-28 19:43:09 ~3 min tests 📄log
✔️ accd406 #3 2023-09-28 19:43:33 ~3 min android 📦tgz
✔️ accd406 #3 2023-09-28 19:43:33 ~3 min ios 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/waku/flags.go Outdated Show resolved Hide resolved
cmd/waku/flags.go Outdated Show resolved Hide resolved
richard-ramos and others added 2 commits September 27, 2023 11:04
Co-authored-by: Prem Chaitanya Prathi <chaitanyaprem@gmail.com>
@richard-ramos richard-ramos merged commit 88d69eb into master Sep 28, 2023
10 of 11 checks passed
@richard-ramos richard-ramos deleted the force-reachability branch September 28, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants