Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: container image workflow #792

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

romanzac
Copy link
Collaborator

@romanzac romanzac commented Oct 3, 2023

Description

Github workflow to build docker images for testing

Changes

  • Workflow file
  • Docker file

Tests

It has been tested with quay.io docker registry and go-waku repo specific credentials. Final test result visible at https://github.com/waku-org/go-waku/actions/runs/6392816182

@status-im-auto
Copy link

status-im-auto commented Oct 3, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 24a7e2f #1 2023-10-03 13:51:57 ~2 min nix-flake 📄log
✔️ 24a7e2f #1 2023-10-03 13:52:17 ~2 min linux 📦deb
✔️ 24a7e2f #1 2023-10-03 13:53:04 ~3 min tests 📄log
✔️ 24a7e2f #1 2023-10-03 13:53:51 ~4 min android 📦tgz
✔️ 24a7e2f #1 2023-10-03 13:53:53 ~4 min tests 📄log
✔️ 24a7e2f #1 2023-10-03 13:57:08 ~7 min ios 📦tgz

Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a question: are the dockerfile from docker/ folder and the one in the root folder seem to be the same? is this okay? or maybe it's missing a commit?

@romanzac
Copy link
Collaborator Author

romanzac commented Oct 4, 2023

LGTM. Just a question: are the dockerfile from docker/ folder and the one in the root folder seem to be the same? is this okay? or maybe it's missing a commit?

Dockerfiles in /docker might be for testing, unless we agree otherwise. There are few differences in labels and bumped Go version. Initially, I didn't want to interfere with Dockerfile created by devs. Later we may also think about reference build images for different platforms and have them published on DockerHub.

@romanzac romanzac merged commit 9017f98 into master Oct 5, 2023
12 of 13 checks passed
@romanzac romanzac deleted the test-container-image-workflow branch October 5, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants