Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: msg digest matches msg hash #820

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: msg digest matches msg hash #820

merged 2 commits into from
Oct 20, 2023

Conversation

richard-ramos
Copy link
Member

Description

Previously the digest was missing the pubsub topic and meta. With this PR we just use the message hash as digest so it contains these attributes

@status-im-auto
Copy link

status-im-auto commented Oct 20, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b063266 #1 2023-10-20 15:18:34 ~2 min nix-flake 📄log
✔️ b063266 #1 2023-10-20 15:18:44 ~2 min linux 📦deb
✔️ b063266 #1 2023-10-20 15:20:01 ~3 min tests 📄log
✔️ b063266 #1 2023-10-20 15:20:07 ~3 min tests 📄log
✔️ b063266 #1 2023-10-20 15:20:40 ~4 min ios 📦tgz
✔️ b063266 #1 2023-10-20 15:20:41 ~4 min android 📦tgz
✔️ 693997b #2 2023-10-20 20:05:35 ~2 min nix-flake 📄log
✔️ 693997b #2 2023-10-20 20:05:59 ~2 min linux 📦deb
✔️ 693997b #2 2023-10-20 20:06:48 ~3 min tests 📄log
✔️ 693997b #2 2023-10-20 20:07:02 ~3 min tests 📄log
✔️ 693997b #2 2023-10-20 20:07:25 ~3 min ios 📦tgz
✔️ 693997b #2 2023-10-20 20:07:39 ~4 min android 📦tgz

chaitanyaprem
chaitanyaprem approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 4181655 into master Oct 20, 2023
11 checks passed
@richard-ramos richard-ramos deleted the feat/digest branch October 20, 2023 20:25
@fbarbu15 fbarbu15 mentioned this pull request Oct 24, 2023
Closed
@ABresting ABresting mentioned this pull request Oct 26, 2023
Closed
richard-ramos added a commit that referenced this pull request Oct 30, 2023
@richard-ramos
revert(#820): msg digest matches msg hash
cf82f66
@ABresting ABresting mentioned this pull request Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@harsh-98 harsh-98 Awaiting requested review from harsh-98

Assignees

@richard-ramos richard-ramos

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richard-ramos @status-im-auto @chaitanyaprem