Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify store test to not depend on order of msgs #832

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Oct 24, 2023

Description

Issue due to macOS/darwin time precision.
macOS/darwin time is maintained/returned only at microsecond granularity and not at nanosecond granularity. This was the reason for failure of the test. As the test is not meant to depend on timestamps, it has been modified to address the issue.
https://groups.google.com/g/golang-dev/c/DboHw1eCiSc?pli=1

Changes

  • Rather than depending on order of messages in validating the test, test now validates whether all 3 messages are retrieved

@status-im-auto
Copy link

status-im-auto commented Oct 24, 2023

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e7d6e99 #1 2023-10-24 21:28:22 ~1 min nix-flake 📄log
✔️ e7d6e99 #1 2023-10-24 21:28:49 ~2 min linux 📦deb
✔️ e7d6e99 #1 2023-10-24 21:29:49 ~3 min tests 📄log
✔️ e7d6e99 #1 2023-10-24 21:30:01 ~3 min tests 📄log
✔️ e7d6e99 #1 2023-10-24 21:30:41 ~4 min android 📦tgz
✔️ e7d6e99 #1 2023-10-24 21:30:57 ~4 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 493d234 #2 2023-10-24 21:58:07 ~1 min linux 📦deb
✔️ 493d234 #2 2023-10-24 21:58:50 ~1 min tests 📄log
✔️ 493d234 #2 2023-10-24 21:58:53 ~1 min nix-flake 📄log
✔️ 493d234 #2 2023-10-24 21:59:19 ~2 min tests 📄log
✔️ 493d234 #2 2023-10-24 22:00:29 ~3 min android 📦tgz
✔️ 493d234 #2 2023-10-24 22:00:33 ~3 min ios 📦tgz
✔️ 4a0e4f1 #3 2023-10-24 21:59:11 ~1 min linux 📦deb
✔️ 4a0e4f1 #3 2023-10-24 22:00:00 ~1 min tests 📄log
✔️ 4a0e4f1 #3 2023-10-24 22:00:48 ~1 min nix-flake 📄log
✔️ 4a0e4f1 #3 2023-10-24 22:02:19 ~4 min ios 📦tgz
✔️ 4a0e4f1 #3 2023-10-24 22:02:39 ~3 min tests 📄log
✔️ 4a0e4f1 #3 2023-10-24 22:03:41 ~3 min android 📦tgz

Co-authored-by: richΛrd <info@richardramos.me>
@chaitanyaprem chaitanyaprem merged commit 18c16de into master Oct 24, 2023
11 checks passed
@chaitanyaprem chaitanyaprem deleted the fix/store-test branch October 24, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants