feat: On Demand Peer Discovery based on shard and service #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge inter-dependencies
3 tasks
Jenkins BuildsClick to see older builds (128)
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chaitanyaprem
changed the title
| return peerID, nil | ||
| } else if !errors.Is(err, ErrNoPeersAvailable) { | ||
| pm.logger.Debug("could not retrieve random peer from slot", zap.String("protocol", string(criteria.Proto)), | ||
| zap.String("pubsubTopic", criteria.PubsubTopic), zap.Error(err)) |
Check failure
Code scanning / CodeQL
Log entries created from user input High
| if err == nil { | ||
| return peerID, nil | ||
| } else { | ||
| pm.logger.Debug("Discovering peers by pubsubTopic", zap.String("pubsubTopic", pubsubTopic)) |
Check failure
Code scanning / CodeQL
Log entries created from user input High
richard-ramos
approved these changes
Nov 7, 2023
Co-authored-by: richΛrd <info@richardramos.me>
| pm.logger.Error("failed to discover and conenct to peers", zap.Error(err)) | ||
| } | ||
| } else { | ||
| pm.logger.Debug("failed to convert pubsub topic to shard as topic is named pubsubTopic", zap.String("topic", pubsubTopic)) |
Check failure
Code scanning / CodeQL
Log entries created from user input High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ability to discover peers on demand based on shard and service. This would help lightclients and relay nodes during new shard subscription in reducing wait time in discovery.
Changes
Tests