Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filter-subscribe): params.selectedPeer not set #836

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix(filter-subscribe): params.selectedPeer not set #836

merged 3 commits into from
Oct 25, 2023

Conversation

harsh-98
Copy link
Contributor

@harsh-98 harsh-98 commented Oct 25, 2023 •
edited
Loading

Description

Bug found like working on #746. In subscribe if params.selectPeer is missing, we select peer from peer manager. But the selected peer is not being passed to wf.request.

Changes

Tests

  • Test are being written as part of FilterRest PR.

@status-im-auto
Copy link

status-im-auto commented Oct 25, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0b5d133 #1 2023-10-25 08:55:16 ~1 min nix-flake 📄log
✔️ 0b5d133 #1 2023-10-25 08:55:46 ~2 min linux 📦deb
✔️ 0b5d133 #1 2023-10-25 08:56:41 ~3 min tests 📄log
✔️ 0b5d133 #1 2023-10-25 08:57:19 ~3 min tests 📄log
✔️ 0b5d133 #1 2023-10-25 08:57:42 ~4 min ios 📦tgz
✔️ 0b5d133 #1 2023-10-25 08:57:58 ~4 min android 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4e3e8a7 #2 2023-10-25 21:47:25 ~1 min nix-flake 📄log
✔️ 4e3e8a7 #2 2023-10-25 21:47:28 ~1 min tests 📄log
✔️ 4e3e8a7 #2 2023-10-25 21:47:54 ~2 min linux 📦deb
✔️ 4e3e8a7 #2 2023-10-25 21:49:02 ~3 min tests 📄log
✔️ 4e3e8a7 #2 2023-10-25 21:49:19 ~3 min ios 📦tgz
✔️ 4e3e8a7 #2 2023-10-25 21:49:36 ~4 min android 📦tgz
✔️ 70c2f79 #3 2023-10-25 21:59:44 ~2 min nix-flake 📄log
✔️ 70c2f79 #3 2023-10-25 22:00:51 ~3 min linux 📦deb
✔️ 70c2f79 #3 2023-10-25 22:01:59 ~4 min tests 📄log
✔️ 70c2f79 #3 2023-10-25 22:02:07 ~4 min ios 📦tgz
✔️ 70c2f79 #3 2023-10-25 22:02:08 ~4 min android 📦tgz
✔️ 70c2f79 #3 2023-10-25 22:05:27 ~7 min tests 📄log

@harsh-98 harsh-98 mentioned this pull request Oct 25, 2023
Merged
5 tasks
@chaitanyaprem chaitanyaprem mentioned this pull request Oct 25, 2023
Merged
chaitanyaprem
chaitanyaprem approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsh-98 harsh-98 merged commit 0ba8b2c into master Oct 25, 2023
10 of 11 checks passed
@harsh-98 harsh-98 deleted the FixEmptyPeer branch October 25, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

Assignees

@harsh-98 harsh-98

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harsh-98 @status-im-auto @chaitanyaprem