Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscription-map): uniform operations and encapsulation #853

Merged
merged 5 commits into from
Nov 4, 2023

Conversation

harsh-98
Copy link
Contributor

@harsh-98 harsh-98 commented Oct 31, 2023

Description

Refactor before adding getMessage to filter rest module. Related to #746.

Changes

  • Don't expose items from subscriptionMap.
  • In filter unsubscribe/unsubscribeAll, return list of err instead of chan. Reason: length of channel not known.
  • maintain a map of pub/contentTopic to number of subscription. This way we can check if there is atleast one subscription for given pair of pubsub/contentTopic. add handle updation of this map on deleteion/creation of subscription. Note: new contentTopics can be added/removed from subscription.

Tests

  • All tests passing.

@status-im-auto
Copy link

status-im-auto commented Oct 31, 2023

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ d35cb06 #1 2023-10-31 18:36:30 ~1 min tests 📄log
✖️ d35cb06 #1 2023-10-31 18:36:30 ~1 min tests 📄log
✔️ d35cb06 #1 2023-10-31 18:36:48 ~1 min nix-flake 📄log
✔️ d35cb06 #1 2023-10-31 18:37:11 ~2 min linux 📦deb
✔️ d35cb06 #1 2023-10-31 18:39:54 ~5 min android 📦tgz
✔️ d35cb06 #1 2023-10-31 18:39:59 ~5 min ios 📦tgz
✔️ b012a53 #2 2023-10-31 18:41:41 ~1 min linux 📦deb
✔️ b012a53 #2 2023-10-31 18:42:32 ~2 min nix-flake 📄log
✔️ b012a53 #2 2023-10-31 18:42:54 ~2 min tests 📄log
✔️ b012a53 #2 2023-10-31 18:43:07 ~2 min tests 📄log
✔️ b012a53 #2 2023-10-31 18:43:52 ~3 min ios 📦tgz
✔️ b012a53 #2 2023-10-31 18:43:57 ~3 min android 📦tgz
✔️ 0fe7eac #3 2023-11-01 14:03:27 ~1 min nix-flake 📄log
✔️ 0fe7eac #3 2023-11-01 14:03:56 ~2 min linux 📦deb
✔️ 0fe7eac #3 2023-11-01 14:04:50 ~3 min tests 📄log
✔️ 0fe7eac #3 2023-11-01 14:05:25 ~3 min ios 📦tgz
✔️ 0fe7eac #3 2023-11-01 14:05:29 ~3 min tests 📄log
✔️ 0fe7eac #3 2023-11-01 14:05:57 ~4 min android 📦tgz
✔️ 3f0253f #4 2023-11-03 13:00:28 ~2 min nix-flake 📄log
✔️ 3f0253f #4 2023-11-03 13:00:33 ~2 min tests 📄log
✔️ 3f0253f #4 2023-11-03 13:00:54 ~2 min linux 📦deb
✔️ 3f0253f #4 2023-11-03 13:01:35 ~3 min android 📦tgz
✔️ 3f0253f #4 2023-11-03 13:01:56 ~3 min ios 📦tgz
✔️ 3f0253f #4 2023-11-03 13:02:17 ~4 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ada9c5c #5 2023-11-03 14:02:07 ~3 min ios 📦tgz
✔️ ada9c5c #5 2023-11-03 14:03:13 ~4 min tests 📄log
✔️ ada9c5c #5 2023-11-03 14:03:19 ~4 min nix-flake 📄log
✔️ ada9c5c #5 2023-11-03 14:03:43 ~5 min linux 📦deb
✔️ ada9c5c #5 2023-11-03 14:04:48 ~6 min android 📦tgz
✔️ ada9c5c #5 2023-11-03 14:05:53 ~7 min tests 📄log
✔️ 99d7144 #6 2023-11-04 07:12:30 ~1 min linux 📦deb
✔️ 99d7144 #6 2023-11-04 07:13:14 ~1 min nix-flake 📄log
✔️ 99d7144 #6 2023-11-04 07:13:47 ~2 min tests 📄log
✔️ 99d7144 #6 2023-11-04 07:14:41 ~3 min ios 📦tgz
✔️ 99d7144 #6 2023-11-04 07:14:49 ~3 min android 📦tgz
✔️ 99d7144 #6 2023-11-04 07:15:03 ~3 min tests 📄log

@harsh-98 harsh-98 marked this pull request as ready for review October 31, 2023 18:44
@harsh-98 harsh-98 merged commit a0bc53c into master Nov 4, 2023
11 checks passed
@harsh-98 harsh-98 deleted the SubMapEncapsulation branch November 4, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants