Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bridge relay topics #854

Merged
merged 3 commits into from
Nov 3, 2023
Merged

feat: bridge relay topics #854

merged 3 commits into from
Nov 3, 2023

Conversation

richard-ramos
Copy link
Member

Description

On today's message reliability call, creating a bridge between pubsub topics was suggested as a way to solve backward compatibility due to the breaking change introduced in status-im/status-go#4161.

This PR adds a hidden --bridge-topic=fromTopic:toTopic flag that can be used to bridge messages from a pubsub topic to another. This is meant to be used with status.prod to get messages going from between the default shard and the default pubsub topic (since mixing named and static sharding introduces a lot of problems).

go-waku nodes must be configured with the following flags:

--bridge-topic=/waku/2/default-waku/proto:/waku/2/rs/16/32 --bridge-topic=/waku/2/rs/16/32:/waku/2/default-waku/proto

(Maybe we can reuse gowaku.prod fleet)

@status-im-auto
Copy link

status-im-auto commented Oct 31, 2023

Jenkins Builds

Click to see older builds (18)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bbce263 #1 2023-10-31 21:07:19 ~2 min nix-flake 📄log
✔️ bbce263 #1 2023-10-31 21:07:32 ~2 min linux 📦deb
✔️ bbce263 #1 2023-10-31 21:08:33 ~3 min tests 📄log
✔️ bbce263 #1 2023-10-31 21:08:38 ~3 min tests 📄log
✔️ bbce263 #1 2023-10-31 21:09:26 ~4 min android 📦tgz
✔️ bbce263 #1 2023-10-31 21:09:33 ~4 min ios 📦tgz
✔️ 579f3c6 #2 2023-11-01 14:19:00 ~1 min linux 📦deb
✔️ 579f3c6 #2 2023-11-01 14:20:04 ~2 min nix-flake 📄log
✔️ 579f3c6 #2 2023-11-01 14:21:19 ~3 min android 📦tgz
✔️ 579f3c6 #2 2023-11-01 14:21:26 ~3 min tests 📄log
✔️ 579f3c6 #2 2023-11-01 14:21:41 ~3 min tests 📄log
✔️ 579f3c6 #2 2023-11-01 14:21:49 ~3 min ios 📦tgz
✔️ 0f04c31 #3 2023-11-02 14:32:26 ~2 min nix-flake 📄log
✔️ 0f04c31 #3 2023-11-02 14:32:51 ~2 min linux 📦deb
✔️ 0f04c31 #3 2023-11-02 14:33:48 ~3 min tests 📄log
✔️ 0f04c31 #3 2023-11-02 14:33:54 ~3 min tests 📄log
✔️ 0f04c31 #3 2023-11-02 14:34:38 ~4 min android 📦tgz
✔️ 0f04c31 #3 2023-11-02 14:41:56 ~11 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 73581d9 #4 2023-11-03 13:20:44 ~1 min linux 📦deb
✔️ 73581d9 #4 2023-11-03 13:21:27 ~1 min nix-flake 📄log
✔️ 73581d9 #4 2023-11-03 13:21:43 ~2 min tests 📄log
✔️ 73581d9 #4 2023-11-03 13:21:54 ~2 min tests 📄log
✔️ 73581d9 #4 2023-11-03 13:23:03 ~3 min android 📦tgz
✔️ 73581d9 #4 2023-11-03 13:23:32 ~4 min ios 📦tgz
✔️ 2ca53cf #5 2023-11-03 13:25:34 ~1 min linux 📦deb
✔️ 2ca53cf #5 2023-11-03 13:26:17 ~1 min nix-flake 📄log
✔️ 2ca53cf #5 2023-11-03 13:26:28 ~2 min tests 📄log
✔️ 2ca53cf #5 2023-11-03 13:26:52 ~2 min tests 📄log
✔️ 2ca53cf #5 2023-11-03 13:27:47 ~3 min ios 📦tgz
✔️ 2ca53cf #5 2023-11-03 13:28:06 ~3 min android 📦tgz

cmd/waku/relay.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach to solve migration problem.
I am wondering if something like this would be required for other apps like TheGraph that want to migrate from namedpubsubTopic to sharding.

cmd/waku/flags.go Outdated Show resolved Hide resolved
cmd/waku/flags.go Outdated Show resolved Hide resolved
cmd/waku/relay.go Show resolved Hide resolved
cmd/waku/relay.go Show resolved Hide resolved
cmd/waku/relay.go Show resolved Hide resolved
cmd/waku/relay.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit d51c207 into master Nov 3, 2023
10 of 11 checks passed
@richard-ramos richard-ramos deleted the relay-bridge branch November 3, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants