-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bridge relay topics #854
Conversation
Jenkins BuildsClick to see older builds (18)
|
bbce263
to
579f3c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach to solve migration problem.
I am wondering if something like this would be required for other apps like TheGraph that want to migrate from namedpubsubTopic to sharding.
579f3c6
to
0f04c31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
On today's message reliability call, creating a bridge between pubsub topics was suggested as a way to solve backward compatibility due to the breaking change introduced in status-im/status-go#4161.
This PR adds a hidden
--bridge-topic=fromTopic:toTopic
flag that can be used to bridge messages from a pubsub topic to another. This is meant to be used withstatus.prod
to get messages going from between the default shard and the default pubsub topic (since mixing named and static sharding introduces a lot of problems).go-waku nodes must be configured with the following flags:
(Maybe we can reuse
gowaku.prod
fleet)