Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dont' filter out bootnodes #860

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat: dont' filter out bootnodes #860

merged 1 commit into from
Nov 3, 2023

Conversation

richard-ramos
Copy link
Member

Description

This avoids the problem described in waku-org/nwaku#2162

@status-im-auto
Copy link

status-im-auto commented Nov 2, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 00f208d #1 2023-11-02 19:13:11 ~1 min nix-flake 📄log
✔️ 00f208d #1 2023-11-02 19:14:50 ~3 min tests 📄log
✔️ 00f208d #1 2023-11-02 19:14:59 ~3 min tests 📄log
✔️ 00f208d #1 2023-11-02 19:15:54 ~4 min android 📦tgz
✔️ 00f208d #1 2023-11-02 19:25:05 ~13 min ios 📦tgz
✔️ 00f208d #2 2023-11-03 04:46:17 ~2 min linux 📦deb

chaitanyaprem
chaitanyaprem approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsh-98
Copy link
Contributor

harsh-98 commented Nov 3, 2023

lgtm. One question, why is defaultPredicate exposed?

@richard-ramos
Copy link
Member Author

lgtm. One question, why is defaultPredicate exposed?

I was thinking that someone using the PeerIterator function might be interested in also have a predicate that does the filtering of shards discv5 does by default. Perhaps it could even be used here

go-waku/waku/v2/protocol/peer_exchange/protocol.go

Line 143 in 02f2800

iterator, err := wakuPX.disc.PeerIterator()
as I see there's no particular filtering being applied to the nodes being returned by discv5

@richard-ramos richard-ramos merged commit e0c6ab8 into master Nov 3, 2023
13 checks passed
@richard-ramos richard-ramos deleted the feat/dont-filter-out-bootnodes branch November 3, 2023 13:23
@jm-clius
Copy link

jm-clius commented Nov 3, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@harsh-98 harsh-98 harsh-98 approved these changes

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees

@richard-ramos richard-ramos

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richard-ramos @status-im-auto @harsh-98 @jm-clius @chaitanyaprem