Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer-exchange: dappnode advertises ws instead of wss #1526

Closed
Tracked by #1429
danisharora099 opened this issue Sep 2, 2023 · 3 comments
Closed
Tracked by #1429

peer-exchange: dappnode advertises ws instead of wss #1526

danisharora099 opened this issue Sep 2, 2023 · 3 comments

Comments

@danisharora099
Copy link
Collaborator

This is a bug report

Problem

During investigation around peer-exchange in browser (#1454), it was found out that some of the nodes run in dappnode actually advertise ws ports instead of wss probably because TLS is handled by a proxy within dappnode

This issue is to track the correct advertisement within dappnode, and their reachability.


@mfw78 is this something you can help look into perhaps?

@mfw78
Copy link

mfw78 commented Sep 2, 2023

From my understanding there is no method to restrict what gets advertised (you can only add additional multiaddrs), so they are advertising both ws and wss.

Refer: rndlabs/dappnodepackage-nwaku@a52fdd1

Additionally, with reference to: https://dappnode.github.io/explorer/#/repo/0x5d670ca64807332e5a1a3d1364c339fe0c472bad it appears that the dappnode package hasn't been updated in some time.

The IPFS hashes that are pushed can be seen in the action run logs within the https://github.com/rndlabs/dappnodepackage-nwaku repository.

For better maintenance of this repo, I'm very happy to transfer this repository to the waku-org organisation.

cc @alrevuelta @fryorcraken

@danisharora099
Copy link
Collaborator Author

danisharora099 commented Sep 7, 2023

future optimisation:

  • track work to only allow the wss on the libp2p transport, but allow non-secure websockets in localhost @danisharora099

@danisharora099
Copy link
Collaborator Author

danisharora099 commented Sep 7, 2023

From my understanding there is no method to restrict what gets advertised (you can only add additional multiaddrs), so they are advertising both ws and wss.

Thank you for the information, @mfw78 -- this is very helpful.
Looks like we can safely ignore the ws addresses in that case.

Future work tracked here: #1547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants