Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only allow secure websockets on transport #1547

Closed
Tracked by #1453
danisharora099 opened this issue Sep 7, 2023 · 1 comment · Fixed by #1989
Closed
Tracked by #1453

only allow secure websockets on transport #1547

danisharora099 opened this issue Sep 7, 2023 · 1 comment · Fixed by #1989
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@danisharora099
Copy link
Collaborator

This is a bug report/feature or change request/support request

Problem

js-waku currently filters and tries to dial all peers that support websockets on the transport level. this leads to a lot of failures when dialing from browsers.

Proposed Solutions

we can perhaps limit that to only allow secure websockets (wss), but allow non-secure websockets (ws) on localhost if possible.

Notes

@weboko
Copy link
Collaborator

weboko commented Apr 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants