Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DNS Discovery by default #517

Closed
7 tasks done
D4nte opened this issue Feb 11, 2022 · 7 comments · Fixed by #1084
Closed
7 tasks done

Use DNS Discovery by default #517

D4nte opened this issue Feb 11, 2022 · 7 comments · Fixed by #1084
Assignees
Labels
track:discovery Discovery track (Secure Messaging/Waku Product) track:network-testing Network testing track (Secure Messaging/Waku Product)
Projects

Comments

@D4nte
Copy link
Contributor

D4nte commented Feb 11, 2022

Problem

DNS Discovery is a more decentralized and flexible strategy than using the (hardcoded) predefineded Status nodes.
We expect node operators and platforms to use DNS Discovery (either Status' one or their own) until more dynamic discovery mechanisms are in place (such as peer exchange).

Definition of Done

  • Confirm that nwaku native websocket support is now stable
  • Include a live data (not enabled in CI) test that uses DNS peer discovery with createLightClient
  • Use DNS Discovery in the web-chat example
  • Set DNS Discovery as the default bootstrap method
@D4nte D4nte added this to New in js-waku Feb 11, 2022
@D4nte D4nte moved this from New to Pending Author in js-waku Feb 11, 2022
@D4nte D4nte added the blocked This issue is blocked by some other work label Feb 11, 2022
@D4nte D4nte moved this from Pending Author to Icebox in js-waku Feb 11, 2022
This was referenced Feb 11, 2022
@D4nte D4nte moved this from Icebox to Backlog (groomed) in js-waku Apr 13, 2022
@D4nte D4nte removed the blocked This issue is blocked by some other work label Apr 13, 2022
@fryorcraken fryorcraken added track:discovery Discovery track (Secure Messaging/Waku Product) track:network-testing Network testing track (Secure Messaging/Waku Product) labels Aug 25, 2022
@fryorcraken fryorcraken moved this from Backlog to Moved to Waku Product Project in js-waku Aug 26, 2022
@fryorcraken
Copy link
Collaborator

  • peer exchange

@fryorcraken
Copy link
Collaborator

Use DNS Discovery in the web-chat example

Must be done first and some dogfooding needs to happen before we can consider dns discovery ready.

@danisharora099
Copy link
Collaborator

Use DNS Discovery in the web-chat example

Must be done first and some dogfooding needs to happen before we can consider dns discovery ready.

Wouldn't we need for the PR to be merged before we can test it in our example? How would we go about using an unmerged/unreleased version without building locally?
(#1114 (comment))

@weboko
Copy link
Collaborator

weboko commented Jan 11, 2023

I think what @fryorcraken suggests is to hide if behind a feature flag so that consumers can pass an option and use experimental functionality intentionally without breaking old contract.

@danisharora099
Copy link
Collaborator

My bad.
The idea is to test DNS discovery before merging it as a default discovery mechanism. (#1114 (comment))

@danisharora099
Copy link
Collaborator

Update: DNS Discovery used in the web-chat example here waku-org/examples.waku.org#190

@danisharora099
Copy link
Collaborator

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:discovery Discovery track (Secure Messaging/Waku Product) track:network-testing Network testing track (Secure Messaging/Waku Product)
Projects
Archived in project
js-waku
Moved to Waku Product Project
Development

Successfully merging a pull request may close this issue.

4 participants