Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manually triggerr ci with custom nim node image #1510

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

fbarbu15
Copy link
Collaborator

Problem

While doing a release testing it's important to tests with different versions of the Nim node

Solution

Added workflow dispatch event and added the nim node as a github action input

Notes

@fbarbu15 fbarbu15 requested a review from a team as a code owner August 28, 2023 14:07
@fbarbu15 fbarbu15 changed the title manually triggerr ci with custom nim node image chore: manually triggerr ci with custom nim node image Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 30.75 KB (0%) 616 ms (0%) 291 ms (-0.81% 🔽) 906 ms
Waku Simple Light Node 296.36 KB (0%) 6 s (0%) 876 ms (+0.28% 🔺) 6.9 s
ECIES encryption 28.68 KB (0%) 574 ms (0%) 222 ms (-27.52% 🔽) 796 ms
Symmetric encryption 28.69 KB (0%) 574 ms (0%) 320 ms (+28.58% 🔺) 894 ms
DNS discovery 118.6 KB (0%) 2.4 s (0%) 579 ms (+2.1% 🔺) 3 s
Privacy preserving protocols 122.43 KB (0%) 2.5 s (0%) 492 ms (-2.47% 🔽) 3 s
Light protocols 30.53 KB (0%) 611 ms (0%) 310 ms (-1.05% 🔽) 921 ms
History retrieval protocols 29.72 KB (0%) 595 ms (0%) 398 ms (+32.54% 🔺) 992 ms
Deterministic Message Hashing 5.78 KB (0%) 116 ms (0%) 68 ms (-45.33% 🔽) 183 ms

@fbarbu15
Copy link
Collaborator Author

@fryorcraken can you please add me to js-waku developers so I can merge PRs? Thanks

@danisharora099
Copy link
Collaborator

danisharora099 commented Aug 29, 2023

looks like the CI hasn't successfully ran -- are we sure the ci.yml file is correct? usually happens when it isn't

@fbarbu15
Copy link
Collaborator Author

looks like the CI hasn't successfully ran -- are we sure the ci.yml file is correct? usually happens when it isn't

Thanks for catching this, indeed I have a syntax error: https://github.com/waku-org/js-waku/actions/runs/6011785546
Strange that I didn't get any notifications, maybe I need to be in the js-waku group to get them
Will fix this asap

@fbarbu15
Copy link
Collaborator Author

looks like the CI hasn't successfully ran -- are we sure the ci.yml file is correct? usually happens when it isn't

Thanks for catching this, indeed I have a syntax error: https://github.com/waku-org/js-waku/actions/runs/6011785546 Strange that I didn't get any notifications, maybe I need to be in the js-waku group to get them Will fix this asap

ci.yml passed

@fryorcraken
Copy link
Collaborator

@fryorcraken can you please add me to js-waku developers so I can merge PRs? Thanks

I added you to Vac group, you should have enough permissions now.

@fbarbu15
Copy link
Collaborator Author

@fryorcraken can you please add me to js-waku developers so I can merge PRs? Thanks

I added you to Vac group, you should have enough permissions now.

Still not permitted to merge. I think it's because of branch protection rules

@fryorcraken fryorcraken merged commit 8537a63 into master Aug 30, 2023
10 checks passed
@fryorcraken fryorcraken deleted the chore/add-dispatch-to-ci branch August 30, 2023 06:28
@fbarbu15 fbarbu15 added the E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants