Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump nwaku version to 0.20 #1591

Merged
merged 2 commits into from
Sep 22, 2023
Merged

chore: bump nwaku version to 0.20 #1591

merged 2 commits into from
Sep 22, 2023

Conversation

fbarbu15
Copy link
Collaborator

Problem

  • Bump nwaku version to 0.20 in the js-waku CI

@github-actions
Copy link

github-actions bot commented Sep 21, 2023 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 27.69 KB (0%) 554 ms (0%) 1.7 s (+0.72% 🔺) 2.3 s
Waku Simple Light Node 262.6 KB (0%) 5.3 s (0%) 5.7 s (+28.65% 🔺) 10.9 s
ECIES encryption 28.7 KB (0%) 574 ms (0%) 2.5 s (+30.1% 🔺) 3.1 s
Symmetric encryption 28.7 KB (0%) 575 ms (0%) 2.1 s (+16.67% 🔺) 2.6 s
DNS discovery 110.62 KB (0%) 2.3 s (0%) 2.5 s (-6.94% 🔽) 4.7 s
Privacy preserving protocols 117.38 KB (0%) 2.4 s (0%) 2.5 s (-24.6% 🔽) 4.8 s
Light protocols 25.83 KB (0%) 517 ms (0%) 1.4 s (-11.08% 🔽) 1.9 s
History retrieval protocols 24.9 KB (0%) 499 ms (0%) 1.2 s (+4.97% 🔺) 1.7 s
Deterministic Message Hashing 5.65 KB (0%) 113 ms (0%) 623 ms (+37.87% 🔺) 736 ms

@fbarbu15 fbarbu15 marked this pull request as ready for review September 21, 2023 10:33
@fbarbu15 fbarbu15 requested a review from a team as a code owner September 21, 2023 10:33
@fbarbu15 fbarbu15 added the E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details label Sep 21, 2023
danisharora099
danisharora099 requested changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danisharora099
danisharora099 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, mis-saw! LGTM :)

@fbarbu15
Copy link
Collaborator Author

sorry, mis-saw! LGTM :)

Thanks, please merge :)

@weboko weboko merged commit 9ab4e86 into master Sep 22, 2023
10 checks passed
@weboko weboko deleted the chore/bump-nwaku branch September 22, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisharora099 danisharora099 danisharora099 approved these changes

Assignees
No one assigned
Labels
E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbarbu15 @danisharora099 @weboko