fix: increase timeout and use tearDownNodes #1592
Conversation
fbarbu15
changed the title
size-limit report 📦
|
fbarbu15
added
the
E:End-to-end testing
|
Seems that it helps a little but doesn't fix the issue fully. Still 1/3 go waku jobs failed |
| !!nwaku && (await nwaku.stop()); | ||
| !!waku && waku.stop().catch((e) => console.log("Waku failed to stop", e)); | ||
| this.timeout(10000); | ||
| tearDownNodes([nwaku], [waku]); |
There was a problem hiding this comment.
Is it only this spec that is failing with such a reason?
|
Did you check the nwaku logs see if there is any indication of the slow shutting down? |
No, I just saw that the default timeout of 2000 ms is hit and increasing it to 10000 helps. My guess is that is somehow related to the |
Might be a bug in the |
are we tracking this bug somewhere? |
…/flaky-teardown
Had a 2nd look and turns out that stop was fired imediately after the message was send and that was the reason for the failures. Adding a small delay seems to fix the issue |
Problem
There are some tests that consistently fail during the CI at teardown (stopping nodes)
Solution
Added a bigger timeout and used the tearDownNodes function that better handles this job