chore(static sharding): add tests for multiple pubsub topics #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarbu15
changed the title
size-limit report 📦
|
fbarbu15
added
the
E:End-to-end testing
fbarbu15
changed the title
fbarbu15
changed the title
danisharora099
approved these changes
Oct 2, 2023
| @@ -14,7 +14,7 @@ export interface Args { | |||
| peerExchange?: boolean; | |||
| discv5Discovery?: boolean; | |||
| storeMessageDbUrl?: string; | |||
| topic?: string; | |||
| topic?: Array<string>; | |||
There was a problem hiding this comment.
Suggested change
| topic?: Array<string>; | |
| topics?: Array<string>; |
There was a problem hiding this comment.
Can't start the nwaku container if I change from topic to topics
I see Unrecognized option 'topics' in the container log
There was a problem hiding this comment.
yes because topic is the flag on nwaku side
i was suggesting an API within js-waku to pass topics which would be translated to --topic: flags
There was a problem hiding this comment.
but imo it's fine to leave it as it is since this is an internal code and keeps things simple
we can address in the future if required
danisharora099
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are no tests with mulitple pubSub topics
Solution
Added new tests for filter, lightPush, filter and store protocol related to multiple pubSub topic feature
Changed existing utils to work with multiple pubSub topics and updated existing tests accordingly