fix: remote peer rejected #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/remote-peer-rejected
…/remote-peer-rejected
fbarbu15
added
the
E:End-to-end testing
size-limit report 📦
|
|
To be merged only when node tests will run on a nwaku version that contains this fix |
danisharora099
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
looks great! thanks @fbarbu15
perhaps we should coordinate with @waku-org/nwaku-developers to check when the next release is happening, and move this to draft until then.
|
@danisharora099 the next release is currently scheduled for 2023-10-18: https://github.com/waku-org/nwaku/milestone/13 @gabrielmer and @vpavlin will prepare the release items. |
1 task
fryorcraken
reviewed
Oct 24, 2023
| @@ -19,7 +19,7 @@ import { | |||
| TestEncoder | |||
| } from "./utils.js"; | |||
|
|
|||
| describe("Waku Light Push", function () { | |||
| describe.only("Waku Light Push", function () { | |||
There was a problem hiding this comment.
Thanks, will keep an eye out for this in the future
This one was removed imediately after with this commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Failing light push tests were returning wrong error message
Solution
Since waku-org/nwaku#1641 was fixed we need to correct the error message in the tests