-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allure test reporting #1668
Conversation
size-limit report 📦
|
…re/test-reports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to create a separate mocharc
for all packages?
@danisharora099 |
@@ -6,6 +6,7 @@ import { getPublicKey } from "./crypto/index.js"; | |||
import { createDecoder, createEncoder } from "./ecies.js"; | |||
|
|||
describe("Ecies Encryption", function () { | |||
this.timeout(20000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR, since I had to replace the mocha config in all packages, I activated parallel runs in the CI for all packages.
And while parallel runs, test are taking longer to execute.
I saw that tests failing in the CI with the test timing out with the default 2000 ms timeout so I've increased it similar with other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these timeouts related to nwaku-jswaku
communication or it's random?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that it's related to either how mocha implements concurrency or by the fact that because we run multiple containers at the same time when running tests in parallel, things start to slow down.
Github actions machine is also pretty low on resources so it's kinda expected to see such timeouts when running tests in parallel.
Those tests run in less than 1 second in serial mode that's why I don't think it's related to waku at all
if: always() && env.ALLURE_REPORTS == 'true' | ||
run: node ci/mergeAllureResults.cjs | ||
|
||
- name: Get allure history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since reports are in the separate repo now - do you think it will slow down if we will continue doing so for long period of time?
Also, as I understand we keep history from the test run in nwaku
, do we differentiate between tests run in js-waku
or nwaku
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
Test results were hard to follow in the console output.
Also we had no history to check flaky tests
Solution
Added allure test reports that are deployed with github pages: https://waku-org.github.io/allure-jswaku/5676/#
Notes