Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: investigate interop test failures #1792

Merged
merged 10 commits into from
Jan 18, 2024
Merged

chore: investigate interop test failures #1792

merged 10 commits into from
Jan 18, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jan 15, 2024

Problem

Interop tests fail agains nwaku release candidate: wakuorg/nwaku:deploy-wakuv2-test

Main reason for that right now is - nwaku seems to be loosing connection to a peer for following tests:
Waku Filter V2 (Named sharding): Multiple PubsubTopics
Waku Store (named sharding), custom pubsub topic

For nwaku it seems to start failing from this waku-org/nwaku@897f487

Solution

Add missing parameters and throws to help catch similar issue in the future.

Upd

Looking into why go-waku still fails.

@weboko weboko marked this pull request as ready for review January 15, 2024 16:06
@weboko weboko requested a review from a team as a code owner January 15, 2024 16:06
Copy link

github-actions bot commented Jan 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 58.52 KB (0%) 1.2 s (0%) 349 ms (+67.21% 🔺) 1.6 s
Waku Simple Light Node 298.58 KB (+0.01% 🔺) 6 s (+0.01% 🔺) 610 ms (+28.29% 🔺) 6.6 s
ECIES encryption 31.97 KB (0%) 640 ms (0%) 176 ms (+17.2% 🔺) 815 ms
Symmetric encryption 31.96 KB (0%) 640 ms (0%) 79 ms (-46.18% 🔽) 719 ms
DNS discovery 106.77 KB (0%) 2.2 s (0%) 437 ms (+48.68% 🔺) 2.6 s
Privacy preserving protocols 145.17 KB (0%) 3 s (0%) 469 ms (+59.97% 🔺) 3.4 s
Light protocols 55.92 KB (+0.04% 🔺) 1.2 s (+0.04% 🔺) 195 ms (-24.25% 🔽) 1.4 s
History retrieval protocols 54.79 KB (0%) 1.1 s (0%) 238 ms (+37.36% 🔺) 1.4 s
Deterministic Message Hashing 5.92 KB (0%) 119 ms (0%) 76 ms (+44.13% 🔺) 194 ms

@weboko weboko requested a review from fbarbu15 January 17, 2024 09:55
Copy link
Collaborator

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adklempner adklempner self-requested a review January 17, 2024 14:55
@weboko weboko merged commit ea4b307 into master Jan 18, 2024
10 of 11 checks passed
@weboko weboko deleted the weboko/interop-tests branch January 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants