Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): append p2p with the multiaddrs from ENR #1817

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Jan 28, 2024

This PR :

  • fixes some of the interop tests with nwaku_master
  • removes debug logs from CI in nwaku_master and go-waku master workflows (unreadable and polluted log lines)
  • minor fixes a getter

Notes:

Copy link

github-actions bot commented Jan 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 32.83 KB (0%) 657 ms (0%) 2 s (+71.45% 🔺) 2.6 s
Waku Simple Light Node 299.19 KB (+0.01% 🔺) 6 s (+0.01% 🔺) 4.4 s (+39.68% 🔺) 10.4 s
ECIES encryption 31.99 KB (0%) 640 ms (0%) 1.1 s (+30.59% 🔺) 1.8 s
Symmetric encryption 31.98 KB (0%) 640 ms (0%) 1.7 s (+87.15% 🔺) 2.3 s
DNS discovery 106.74 KB (+0.02% 🔺) 2.2 s (+0.02% 🔺) 2.5 s (+14.13% 🔺) 4.6 s
Privacy preserving protocols 129.48 KB (0%) 2.6 s (0%) 2.6 s (+8.41% 🔺) 5.2 s
Light protocols 30.87 KB (0%) 618 ms (0%) 946 ms (+12.17% 🔺) 1.6 s
History retrieval protocols 29.33 KB (0%) 587 ms (0%) 855 ms (-11.71% 🔽) 1.5 s
Deterministic Message Hashing 5.92 KB (0%) 119 ms (0%) 538 ms (+87.98% 🔺) 657 ms

@danisharora099 danisharora099 changed the title chore: append p2p with the multiaddrs from ENR fix(tests): append p2p with the multiaddrs from ENR Jan 29, 2024
@danisharora099 danisharora099 marked this pull request as ready for review January 30, 2024 09:37
@danisharora099 danisharora099 requested a review from a team as a code owner January 30, 2024 09:37
@danisharora099 danisharora099 merged commit f8e02ab into master Feb 6, 2024
9 of 10 checks passed
@danisharora099 danisharora099 deleted the chore/add-p2p-multiaddrs branch February 6, 2024 20:27
@weboko weboko mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants