Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: nwaku latest fixes #1844

Merged
merged 5 commits into from
Feb 14, 2024
Merged

chore: nwaku latest fixes #1844

merged 5 commits into from
Feb 14, 2024

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Feb 13, 2024 •
edited

Problem

Fixes for failures with nwaku latest.
All green

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 36.2 KB (0%) 724 ms (0%) 255 ms (+30.62% 🔺) 979 ms
Waku Simple Light Node 278.28 KB (0%) 5.6 s (0%) 629 ms (+48.85% 🔺) 6.2 s
ECIES encryption 32.01 KB (0%) 641 ms (0%) 160 ms (-20.07% 🔽) 801 ms
Symmetric encryption 32 KB (0%) 641 ms (0%) 156 ms (+10.22% 🔺) 796 ms
DNS discovery 107.71 KB (0%) 2.2 s (0%) 509 ms (+34.34% 🔺) 2.7 s
Privacy preserving protocols 128.92 KB (0%) 2.6 s (0%) 324 ms (-20.04% 🔽) 3 s
Light protocols 34.27 KB (0%) 686 ms (0%) 232 ms (-17.72% 🔽) 917 ms
History retrieval protocols 32.71 KB (0%) 655 ms (0%) 145 ms (+12.16% 🔺) 799 ms
Deterministic Message Hashing 5.96 KB (0%) 120 ms (0%) 55 ms (+37.69% 🔺) 174 ms

@fbarbu15 fbarbu15 marked this pull request as ready for review February 13, 2024 16:39
@fbarbu15 fbarbu15 requested a review from a team as a code owner February 13, 2024 16:39
danisharora099
danisharora099 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@fbarbu15 fbarbu15 merged commit a9fb796 into master Feb 14, 2024
10 checks passed
@fbarbu15 fbarbu15 deleted the chore/nwaku-latest-fixes branch February 14, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisharora099 danisharora099 danisharora099 approved these changes

@weboko weboko weboko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbarbu15 @danisharora099 @weboko