Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unskip shard 0 test fixed by 1874 #1978

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Apr 25, 2024

Problem

Un-skipping test because #1874 was closed as completed via #1885.

Solution

Notes

  • Resolves
  • Related to

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 180.73 KB (0%) 3.7 s (0%) 2.5 s (+9.56% 🔺) 6.1 s
Waku Simple Light Node 180.86 KB (0%) 3.7 s (0%) 2 s (-12.17% 🔽) 5.6 s
ECIES encryption 23.11 KB (0%) 463 ms (0%) 522 ms (+9.65% 🔺) 984 ms
Symmetric encryption 22.59 KB (0%) 452 ms (0%) 559 ms (-6.24% 🔽) 1.1 s
DNS discovery 72.42 KB (0%) 1.5 s (0%) 574 ms (-40.66% 🔽) 2.1 s
Peer Exchange discovery 73.96 KB (0%) 1.5 s (0%) 1.1 s (-30.46% 🔽) 2.6 s
Local Peer Cache Discovery 67.64 KB (0%) 1.4 s (0%) 1.9 s (+72.48% 🔺) 3.2 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 617 ms (-28.2% 🔽) 1.4 s
Waku Filter 111.25 KB (0%) 2.3 s (0%) 1.8 s (+23.96% 🔺) 4.1 s
Waku LightPush 110.23 KB (0%) 2.3 s (0%) 2 s (+142.7% 🔺) 4.2 s
History retrieval protocols 110.71 KB (0%) 2.3 s (0%) 1.6 s (+3.28% 🔺) 3.8 s
Deterministic Message Hashing 4.83 KB (0%) 97 ms (0%) 52 ms (-9.21% 🔽) 149 ms

@fbarbu15 fbarbu15 marked this pull request as ready for review April 25, 2024 09:43
@fbarbu15 fbarbu15 requested a review from a team as a code owner April 25, 2024 09:43
@danisharora099
Copy link
Collaborator

thanks!

@danisharora099 danisharora099 merged commit 86249df into master Apr 25, 2024
11 of 12 checks passed
@danisharora099 danisharora099 deleted the test/unskip-shard-0-test branch April 25, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants