Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store): align protocol implementation to use BaseProtocolSDK #2019

Closed
wants to merge 5 commits into from

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented May 16, 2024

Problem

The store protocol currently only uses one peer to make a query - #1685

Solution

  • use multiple peers to query the same paeg
  • find unique messages from that page (remove redundancy)
  • yield the page
  • move on the next page, repeat until done

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

Copy link

github-actions bot commented May 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.37 KB (-0.01% 🔽) 3.7 s (-0.01% 🔽) 4.8 s (-33.14% 🔽) 8.4 s
Waku Simple Light Node 181.67 KB (+0.08% 🔺) 3.7 s (+0.08% 🔺) 4.1 s (-22.72% 🔽) 7.7 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 1.5 s (+121.32% 🔺) 2 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 1.8 s (+38.21% 🔺) 2.3 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 2.8 s (-18.47% 🔽) 4.3 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 3.9 s (-2.79% 🔽) 5.4 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 3.2 s (+10.28% 🔺) 4.5 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 2.7 s (+88.91% 🔺) 3.5 s
Waku Filter 111.98 KB (-0.04% 🔽) 2.3 s (-0.04% 🔽) 4.6 s (+25.3% 🔺) 6.8 s
Waku LightPush 110.39 KB (0%) 2.3 s (0%) 4.5 s (+23.89% 🔺) 6.7 s
History retrieval protocols 111.23 KB (+0.29% 🔺) 2.3 s (+0.29% 🔺) 2.3 s (-45.87% 🔽) 4.5 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 572 ms (-7.23% 🔽) 718 ms

@danisharora099 danisharora099 changed the title feat(store): use multiple peers chore(store): align protocol implementation to use BaseProtocolSDK Jun 5, 2024
@danisharora099
Copy link
Collaborator Author

As concluded in #1685 (comment), this is now being deprioritsed. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Store reliability
1 participant