Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove relay from sdk package #2040

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jun 18, 2024

Problem

sdk package has extra dependencies

Solution

remove them and remove unused full node creator function.

Notes

@weboko weboko requested a review from a team as a code owner June 18, 2024 23:42
Copy link

github-actions bot commented Jun 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 164.79 KB (-10.4% 🔽) 3.3 s (-10.4% 🔽) 16.4 s (-29.72% 🔽) 19.7 s
Waku Simple Light Node 164.82 KB (-10.48% 🔽) 3.3 s (-10.48% 🔽) 17.3 s (-6.92% 🔽) 20.6 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 3.3 s (-48.77% 🔽) 3.7 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 3.5 s (-51.86% 🔽) 3.9 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 13.1 s (-15.39% 🔽) 14.6 s
Peer Exchange discovery 74.22 KB (0%) 1.5 s (0%) 17.3 s (+5.32% 🔺) 18.8 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 13.1 s (-7.82% 🔽) 14.4 s
Privacy preserving protocols 107.3 KB (+176.06% 🔺) 2.2 s (+176.06% 🔺) 13.6 s (+33.45% 🔺) 15.7 s
Waku Filter 110.84 KB (-2.19% 🔽) 2.3 s (-2.19% 🔽) 14.2 s (-31.24% 🔽) 16.4 s
Waku LightPush 108.81 KB (-2.25% 🔽) 2.2 s (-2.25% 🔽) 11 s (-59.18% 🔽) 13.2 s
History retrieval protocols 109.37 KB (-2.19% 🔽) 2.2 s (-2.19% 🔽) 18 s (-36.68% 🔽) 20.2 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 2.4 s (-11.28% 🔽) 2.5 s

Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests that are to be resolved before merge. LGTM

@weboko
Copy link
Collaborator Author

weboko commented Jul 17, 2024

Blocked for now by - https://discord.com/channels/1110799176264056863/1262855908661137449/1262855910985044108
If won't be unblocked - will remove the check as mitigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: encapsulate relay in separate package
3 participants