Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): use protocol peer management #2047

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Jun 21, 2024

Problem

#2046

Solution

Use the logic implemented in #2044 for Filter to get access to the peers managed by the BaseProtocolSDK, instead of relying on getPeers() directly.

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

Copy link

github-actions bot commented Jun 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 183.17 KB (-0.02% 🔽) 3.7 s (-0.02% 🔽) 5.7 s (-5.78% 🔽) 9.4 s
Waku Simple Light Node 183.17 KB (-0.02% 🔽) 3.7 s (-0.02% 🔽) 5.3 s (-18.14% 🔽) 8.9 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 1.3 s (-29.85% 🔽) 1.8 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 2.7 s (+100.23% 🔺) 3.2 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 3.4 s (-12.12% 🔽) 4.9 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 4.5 s (+82.31% 🔺) 6 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 4.7 s (+48.42% 🔺) 6.1 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 2.1 s (+40.52% 🔺) 2.9 s
Waku Filter 112.65 KB (+0.07% 🔺) 2.3 s (+0.07% 🔺) 5.5 s (+41.91% 🔺) 7.8 s
Waku LightPush 111.1 KB (0%) 2.3 s (0%) 2.4 s (-45.66% 🔽) 4.7 s
History retrieval protocols 111.67 KB (0%) 2.3 s (0%) 5.5 s (+26.15% 🔺) 7.7 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 452 ms (+64.93% 🔺) 598 ms

Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, left some questions and before merging - could you, pelase, make light-js example using it?

Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small comments

@danisharora099 danisharora099 merged commit 4db508b into master Jul 3, 2024
11 checks passed
@danisharora099 danisharora099 deleted the feat/filter-peer-mgmt branch July 3, 2024 06:39
@weboko weboko mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(filter): use protocol peer management
2 participants