Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwaku-monitor/pg-exporter-queries: add new panel to show num msgs per shard #43

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Ivansete-status
Copy link
Contributor

In this PR we are showing the number of messages per shard.

The original query (monitoring/configuration/pg-exporter-queries.yml) was designed by @fryorcraken

As a result, we add a panel with the following shape:

image

@NagyZoltanPeter
Copy link
Contributor

What has really changed in nwaku-monitoring.json file, it's hard to see... Maybe some shift cannot be interpreted properly by diff.

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greatt, thanks!

@gabrielmer
Copy link
Contributor

What has really changed in nwaku-monitoring.json file, it's hard to see... Maybe some shift cannot be interpreted properly by diff.

Yes, it's impossible to properly review changes in Grafana dashboards, the diff is always a mess

@Ivansete-status
Copy link
Contributor Author

@NagyZoltanPeter , @gabrielmer - Yes, I absolutely agree that is very difficult to track the changes because that file is modified from the Grafana UI and when moving different components, it gets changed in many places.

When changing the board is a good idea to indicate in the PR description which component in being added.

In this case, you need to trust me that I'm just adding the "# messages per shard" component :)

@Ivansete-status Ivansete-status merged commit 7fca44b into master Feb 2, 2024
@Ivansete-status Ivansete-status deleted the add-shard-stats branch February 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants