fix: change filter request default behaviour to ping (#1721)

waku-org · May 9, 2023 · 7c39be9 · 7c39be9
1 parent 81dffee
commit 7c39be9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/waku/v2/waku_filter_v2/protocol.nim b/waku/v2/waku_filter_v2/protocol.nim
@@ -222,7 +222,7 @@ proc initProtocolHandler(wf: WakuFilter) =
 
     let decodeRes = FilterSubscribeRequest.decode(buf)
     if decodeRes.isErr():
-      error "Failed to decode filter subscribe request", peerId=conn.peerId
+      error "Failed to decode filter subscribe request", peerId=conn.peerId, err=decodeRes.error
       waku_filter_errors.inc(labelValues = [decodeRpcFailure])
       return
 

diff --git a/waku/v2/waku_filter_v2/rpc_codec.nim b/waku/v2/waku_filter_v2/rpc_codec.nim
@@ -37,7 +37,8 @@ proc decode*(T: type FilterSubscribeRequest, buffer: seq[byte]): ProtobufResult[
 
   var filterSubscribeType: uint32
   if not ?pb.getField(2, filterSubscribeType):
-    return err(ProtobufError.missingRequiredField("filter_subscribe_type"))
+    # Revert to ping by default if not set
+    rpc.filterSubscribeType = FilterSubscribeType.SUBSCRIBER_PING
   else:
     rpc.filterSubscribeType = FilterSubscribeType(filterSubscribeType)