Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow to call store api endpoints without a storenode #1575

Closed
alrevuelta opened this issue Feb 24, 2023 · 3 comments
Closed

chore: allow to call store api endpoints without a storenode #1575

alrevuelta opened this issue Feb 24, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@alrevuelta
Copy link
Contributor

The current behavior is that if --storenode is not provided, then the store api handlers are not installed, meaning that get_waku_v2_store_v1_messages is not available.

Wondering if get_waku_v2_store_v1_messages should be available even if --storenode is not provided. With the latest changes adding service peers, we now can fallback to an existing node that implements the store protocol, even if none was provided via store node.

wdyt?
@LNSD
Copy link
Contributor

LNSD commented Mar 3, 2023

That would require a new version of the JSON-RPC endpoint: get_waku_v2_store_v2_messages. This would be a new feature (not a chore nor maintenance).

Are we sure we want to extend the current JSON-RPC? IMO, we should have the wakunode2's API discussion first.

@alrevuelta
Copy link
Contributor Author

@LNSD why do you think we need a new version? The spec is in draft and it doesn't specify anything related to whether --storenode is required or not + it doesn't introduce any breaking changes.

@jm-clius jm-clius added the good first issue Good for newcomers label Mar 14, 2023
@jm-clius jm-clius mentioned this issue Mar 17, 2023
Closed
3 tasks
Ivansete-status added a commit that referenced this issue Mar 30, 2023
@Ivansete-status
feat(rest-api-store): new rest api to retrieve store waku messages (#…
4e6d282 
…1611)

* feat: new rest api based on the current store json-rpc api and
following the same structure as the current relay rest api.

* feat: the store api attend GET requests to retrieve historical messages

* feat: unit tests. Pending to implement the paginagion use cases.

* feat: allow return message to rest-client in case error (4XX or 5XX)

* chore: always allow to call the store api endpoints (json-rpc & rest) without explicit storenode (#1575)
@Ivansete-status Ivansete-status mentioned this issue Mar 30, 2023
Merged
Ivansete-status added a commit that referenced this issue Apr 4, 2023
@Ivansete-status
feat(rest-api-store): new rest api to retrieve store waku messages (#…
791ecb6 
…1611)

* feat: new rest api based on the current store json-rpc api and
following the same structure as the current relay rest api.

* feat: the store api attend GET requests to retrieve historical messages

* feat: unit tests.

* feat: allow return message to rest-client in case error (4XX or 5XX)

* chore: always allow to call the store api endpoints (only rest) without explicit storenode (#1575)
Ivansete-status added a commit that referenced this issue Apr 4, 2023
@Ivansete-status
feat(rest-api-store): new rest api to retrieve store waku messages (#…
b9de7a5 
…1611)

* feat: new rest api based on the current store json-rpc api and
following the same structure as the current relay rest api.

* feat: the store api attend GET requests to retrieve historical messages

* feat: unit tests.

* feat: allow return message to rest-client in case error (4XX or 5XX)

* chore: always allow to call the store api endpoints (only rest) without explicit storenode (#1575)
Ivansete-status added a commit that referenced this issue Apr 4, 2023
@Ivansete-status
chore: allow to call store api endpoints without a storenode (#1575)
b790608
@Ivansete-status Ivansete-status mentioned this issue Apr 4, 2023
Merged
Ivansete-status added a commit that referenced this issue Apr 6, 2023
@Ivansete-status
feat(rest-api-store): new rest api to retrieve store waku messages (#…
41ed541 
…1611)

* feat: new rest api based on the current store json-rpc api and
following the same structure as the current relay rest api.

* feat: the store api attend GET requests to retrieve historical messages

* feat: unit tests.

* feat: allow return message to rest-client in case error (4XX or 5XX)

* chore: always allow to call the store api endpoints (only rest) without explicit storenode (#1575)

* feat: always mounting the current node as storenode client
Ivansete-status added a commit that referenced this issue Apr 6, 2023
@Ivansete-status
feat(rest-api-store): new rest api to retrieve store waku messages (#…
37edab1 
…1611)

* feat: new rest api based on the current store json-rpc api and
following the same structure as the current relay rest api.

* feat: the store api attend GET requests to retrieve historical messages

* feat: unit tests.

* feat: allow return message to rest-client in case error (4XX or 5XX)

* chore: always allow to call the store api endpoints (only rest) without explicit storenode (#1575)

* feat: always mounting the current node as storenode client
Ivansete-status added a commit that referenced this issue Apr 6, 2023
@Ivansete-status
feat(rest-api-store): new rest api to retrieve store waku messages (#…
bca0731 
…1611)

* feat: new rest api based on the current store json-rpc api and
following the same structure as the current relay rest api.

* feat: the store api attend GET requests to retrieve historical messages

* feat: unit tests.

* feat: allow return message to rest-client in case error (4XX or 5XX)

* chore: always allow to call the store api endpoints (only rest) without explicit storenode (#1575)

* feat: always mounting the current node as storenode client
Ivansete-status added a commit that referenced this issue Apr 6, 2023
@Ivansete-status
feat(rest-api-store): new rest api to retrieve store waku messages (#…
b2acb54 
…1611) (#1630)

* feat: new rest api based on the current store json-rpc api and
following the same structure as the current relay rest api.

* feat: the store api attend GET requests to retrieve historical messages

* feat: unit tests.

* feat: allow return message to rest-client in case error (4XX or 5XX)

* chore: always allow to call the store api endpoints (only rest) without explicit storenode (#1575)

* feat: always mounting the current node as storenode client
Ivansete-status added a commit that referenced this issue Apr 6, 2023
@Ivansete-status
chore: allow to call store api endpoints without a storenode (#1575)
87ace11 
* test_jsonrpc_store: testing when there is no peer-store-node available
Ivansete-status added a commit that referenced this issue Apr 6, 2023
@Ivansete-status
chore: allow to call store api endpoints without a storenode (#1575)
bfe8fb8 
* test_jsonrpc_store: testing when there is no peer-store-node available
Ivansete-status added a commit that referenced this issue Apr 6, 2023
@Ivansete-status
chore: allow to call store api endpoints without a storenode (#1575)
3331a7b 
* test_jsonrpc_store: testing when there is no peer-store-node available
Ivansete-status added a commit that referenced this issue Apr 12, 2023
@Ivansete-status
chore: allow to call store api endpoints without a storenode (#1575) (#…
0b4a2e6 
…1647)

* test_jsonrpc_store: testing when there is no peer-store-node available
@Ivansete-status
Copy link
Collaborator

I close as the next PR was merged properly:
#1647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LNSD @alrevuelta @jm-clius @Ivansete-status