feat: integrate new filter protocol, other improvements #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: although tests pass locally, they fail during CI due to a segfault getting triggered on the underlying peerStore attempting to access its |
…grate # Conflicts: # waku/v2/node/waku_node.nim
jm-clius
commented
Apr 4, 2023
There was a problem hiding this comment.
Whitespace changes only. Hide whitespace in GH settings to ignore this file.
jm-clius
commented
Apr 4, 2023
There was a problem hiding this comment.
Hide whitespace in GH settings to view only effective changes in this file.
|
Update: in order to get rid of segfaults and corrupted memory I had to
|
alrevuelta
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is in this PR?
This PR does the following:
What about the legacy filter protocol?
For now, when filter is configured, the node will mount both the new and legacy filter protocols. This is to maintain backwards compatibility until filter clients have dogfooded and switched to the new filter protocol. The idea is to remove all legacy code in the future.
What about the nwaku filter client?
Note that the new filter client has not been integrated yet. Since nwaku is rarely used as a filter client, this client protocol can be integrated and the Filter APIs updated once dogfooding has progressed without supporting the legacy filter client.