Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rln-relay): use new atomic_operation ffi api #1733

Merged
merged 3 commits into from
May 18, 2023
Merged

feat(rln-relay): use new atomic_operation ffi api #1733

merged 3 commits into from
May 18, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented May 16, 2023 •
edited

  • chore(rln-relay): bump zerokit
  • feat(rln-relay): use new atomic_operations ffi api

Description

Uses the new atomic_operation ffi api from zerokit which allows atomic batching of insertions and removals to the
merkle tree.

cc:

Changes

  • insertMembers uses atomicWrite
  • removeMembers uses atomicWrite
  • set_leaves_from has been removed and replaced with atomic_write
  • GroupManager implements new method atomicBatch, which accepts a list of idCommitments to insert, and indices
    to remove, uses atomicWrite

Issue

closes #1729

@rymnc rymnc self-assigned this May 16, 2023
@rymnc rymnc changed the title feat(rln-relay): use new atomic_operation ffi api' feat(rln-relay): use new atomic_operation ffi api May 16, 2023
@rymnc rymnc marked this pull request as ready for review May 16, 2023 10:44
jm-clius
jm-clius approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rymnc rymnc merged commit 611e953 into master May 18, 2023
17 checks passed
@rymnc rymnc deleted the atomic-ops-rln branch May 18, 2023 05:12
@fryorcraken fryorcraken mentioned this pull request Jul 27, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@vpavlin vpavlin Awaiting requested review from vpavlin

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

@richard-ramos richard-ramos Awaiting requested review from richard-ramos

Assignees

@rymnc rymnc

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(rln-relay): use atomic operations api for batching insertions and deletions
2 participants
@rymnc @jm-clius