Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLN: Post-Testnet3 Improvements #605

Closed
10 tasks done
richard-ramos opened this issue Jul 15, 2023 · 9 comments
Closed
10 tasks done

RLN: Post-Testnet3 Improvements #605

richard-ramos opened this issue Jul 15, 2023 · 9 comments
Assignees
@richard-ramos
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details

Comments

@richard-ramos
Copy link
Member

richard-ramos commented Jul 15, 2023 •
edited

Planned start date:
Due date:

Summary

go-waku's RLN feature has fallen behind compared to nwaku. Code equivalent to the following PRs from nwaku must be implemented for go-waku's to be up to date with RLN functionality and also allowing it to be used with the simulation tools

Acceptance Criteria

Tasks

RAID (Risks, Assumptions, Issues and Dependencies)
@richard-ramos richard-ramos self-assigned this Jul 27, 2023
@richard-ramos
Copy link
Member Author

richard-ramos commented Jul 27, 2023 •
edited

nwaku#1777 implemented in #615

@richard-ramos
Copy link
Member Author

richard-ramos commented Jul 27, 2023 •
edited

nwaku#1838 implemented in #612

@richard-ramos
Copy link
Member Author

richard-ramos commented Jul 27, 2023 •
edited

nwaku#1844 implemented in #616

@fryorcraken fryorcraken added milestone Tracks a subteam milestone E:2023-rln labels Aug 3, 2023
@fryorcraken
Copy link
Collaborator

@rymnc are all the functionality listed the one you delivered for testnet 3? I wonder if we can scope this issue to reach testnet 3 feature equivalence.

@rymnc
Copy link

rymnc commented Aug 3, 2023

Yes, and the following are the issues sorted from the retrospective post-testnet 3

vacp2p/research#179 (comment)

@richard-ramos
Copy link
Member Author

nwaku#1733 implemented in #617

@richard-ramos
Copy link
Member Author

richard-ramos commented Aug 4, 2023 •
edited by fryorcraken

Weekly Update

  • achieved: use zerokit batch insert/delete for members, exposed function to retrieve data from merkle tree, modified zerokit and go-zerokit-rln to pass merkle tree persistance configuration settings
  • next: resume onchain sync from persisted tree db

@fryorcraken fryorcraken changed the title chore: get RLN up to date [Milestone] RLN: Post-Testnet3 Improvements Aug 7, 2023
@richard-ramos richard-ramos mentioned this issue Aug 7, 2023
Merged
@richard-ramos
Copy link
Member Author

richard-ramos commented Aug 11, 2023 •
edited

Weekly Update

  • achieved: exposed merkle tree configuration, removed embedded resources from go-zerokit-rln, fixed nwaku / go-waku rlnKeystore compatibility, added merkle tree persistence and modified zerokit to print to stderr any error obtained while executing functions via FFI.
  • next: interop with nwaku

@richard-ramos
Copy link
Member Author

richard-ramos commented Aug 18, 2023 •
edited by fryorcraken

Weekly Update

  • achieved: interop with nwaku.

@fryorcraken fryorcraken changed the title [Milestone] RLN: Post-Testnet3 Improvements RLN: Post-Testnet3 Improvements Sep 22, 2023
@fryorcraken fryorcraken added E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details and removed milestone Tracks a subteam milestone labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-ramos richard-ramos

Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richard-ramos @rymnc @fryorcraken