fix(discv5): Fixing issue that prevented the wakunode2 from starting #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was introduced in PR#1818. Before this commit, the `wakunode2` app crashed with the next error: ERR 2023-06-27 15:57:27.268+00:00 5/7 Starting node and protocols failed topics="wakunode main" tid=1 file=wakunode2.nim:92 error="failed to start waku discovery v5: "
jakubgs
approved these changes
Jun 27, 2023
SionoiS
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue was introduced in PR#1818.
Before this commit, the
wakunode2app crashed with the next error:ERR 2023-06-27 15:57:27.268+00:00 5/7 Starting node and protocols failed topics="wakunode main" tid=1 file=wakunode2.nim:92 error="failed to start waku discovery v5: "
To replicate the issue, and the corresponding fix, just do:
cfg_node_a.txt