feat(rln-relay): close db connection appropriately #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
fix-unwrap-bug
branch
2 times, most recently
from
ee3a505
to
f0a28e9
Compare
rymnc
requested review from
Ivansete-status,
jm-clius,
vpavlin,
SionoiS and
alrevuelta
rymnc
force-pushed
the
fix-unwrap-bug
branch
4 times, most recently
from
547fa03
to
97969d2
Compare
vpavlin
reviewed
Jul 26, 2023
| @@ -62,7 +62,8 @@ type | |||
| const DefaultKeyStorePath* = "rlnKeystore.json" | |||
| const DefaultKeyStorePassword* = "password" | |||
|
|
|||
| const BlockChunkSize* = 100'u64 | |||
| const DecayFactor* = 1.2 | |||
There was a problem hiding this comment.
Is this decay for block chunk size added by mistake to this PR? Does not seem to be really related to "close db connection" (or am I missing something?)
There was a problem hiding this comment.
unfortunately, while I was testing this fix, I discovered a bug related to the chunking of blocks, so I included it in this PR to ensure some stability - can remove if you'd like!
There was a problem hiding this comment.
Fine by me, just wanted to make sure this was intentional:)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the connection to the pmtree database gracefully
Description
Changes
flushwaku_node.stop()is called