Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): execute js-waku integration tests on image build #2006

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Sep 7, 2023

Description

Depends on waku-org/js-waku#1541 (merged)

This PR adds another step in our CI workflow - it executes js-waku tests on top of the image built from a PR - you can think of this as an integration test attempt

Changes

  • add reusable workflow from js-waku
  • update PR image build comment to also mention the commit hash (cc @alrevuelta)

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the experimental image built from this PR at

quay.io/wakuorg/nwaku-pr:2006-experimental

@vpavlin vpavlin marked this pull request as draft September 7, 2023 14:24
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2006

@vpavlin vpavlin marked this pull request as ready for review September 8, 2023 08:57
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vpavlin vpavlin merged commit 5d976df into master Sep 8, 2023
32 checks passed
@vpavlin vpavlin deleted the chore/exec-js-waku-ci branch September 8, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants