chore(release): update changelog for v0.20.0 release #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavlin
requested review from
jm-clius,
rymnc,
SionoiS,
alrevuelta,
NagyZoltanPeter,
Ivansete-status and
gabrielmer
and removed request for
jm-clius
SionoiS
approved these changes
Sep 12, 2023
CHANGELOG.md
Outdated
| * RLN is now part of standard release (is no longer EXPERIMENTAL feature) | ||
| * Interop tests between nwaku and js-waku are now gating PRs and releases | ||
| * Libwaku has been made threadsafe | ||
| * Autosharding being implementated across various protocols |
There was a problem hiding this comment.
Suggested change
| * Autosharding being implementated across various protocols | |
| * Made various protocol implementations use autosharding. |
There was a problem hiding this comment.
I want it to be clear that the protocols did not change only the impl. Not sure if it's clearer but 🤷
There was a problem hiding this comment.
How about just * Added autosharding option on various protocol APIs. This is simply a change to make the API (internal/external) more flexible
jm-clius
approved these changes
Sep 12, 2023
CHANGELOG.md
Outdated
| * RLN is now part of standard release (is no longer EXPERIMENTAL feature) | ||
| * Interop tests between nwaku and js-waku are now gating PRs and releases | ||
| * Libwaku has been made threadsafe | ||
| * Autosharding being implementated across various protocols |
There was a problem hiding this comment.
How about just * Added autosharding option on various protocol APIs. This is simply a change to make the API (internal/external) more flexible
Ivansete-status
approved these changes
Sep 12, 2023
Co-authored-by: Ivan Folgueira Bande <128452529+Ivansete-status@users.noreply.github.com>
Co-authored-by: Simon-Pierre Vivier <simvivier@status.im>
rymnc
reviewed
Sep 13, 2023
CHANGELOG.md
Outdated
| * Interop tests between nwaku and js-waku are now gating PRs and releases | ||
| * Libwaku has been made more threadsafe (1 out of 3 improvements applied.) | ||
| * Added autosharding option on various protocol APIs | ||
| * TODO: @rymnc https://github.com/waku-org/nwaku/pull/1966 |
There was a problem hiding this comment.
@vpavlin here we need to write that the rln-relay-membership-group-index flag has been removed, along with rln-relay-pubsub-topic and rln-relay-content-topic
rymnc
approved these changes
Sep 13, 2023
NagyZoltanPeter
approved these changes
Sep 13, 2023
|
Looks great :) Thanks! |
gabrielmer
approved these changes
Sep 13, 2023
vpavlin
force-pushed
the
chore/changelog-v0.20.0
branch
from
efb91ef
to
0d482ae
Compare
vpavlin
added a commit
that referenced
this pull request
Sep 14, 2023
* chore(release): update changelog for v0.20.0 release * Update CHANGELOG.md Co-authored-by: Ivan Folgueira Bande <128452529+Ivansete-status@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Simon-Pierre Vivier <simvivier@status.im> * fix typo and autosharding highlight, note CLI options removal --------- Co-authored-by: Ivan Folgueira Bande <128452529+Ivansete-status@users.noreply.github.com> Co-authored-by: Simon-Pierre Vivier <simvivier@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog for v0.20.0
Please review carefully, suggest highlights or upgrade instructions (we should probably emphasize RLN no longer being experimental and maybe point to RLN docs in upgrade instructions?)
@rymnc I meantioned you in highlights because you flagged the issue with
release-noteslabel, but I am not sure what specifically would you like to highlight:)Changes