chore: resolving DNS IP and publishing it when no extIp provided #2030

gabrielmer · 2023-09-13T09:39:40Z

Description

When running a node and no external IP is provided but a DNS4 address is, we want the ENR to use the resolved DNS IP instead of using 0.0.0.0, which is currently the case.

Changes

If there's no external IP but a DNS address was provided, do a DNS IP lookup and use the result as external IP in the node's network configuration
Updated procedure newTestWakuNode to account for the above scenario
Added test cases for the success and failure flows of the DNS lookup

Issue

closes #1576

github-actions · 2023-09-13T09:45:18Z

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2030

Built from 13732cd

apps/wakunode2/internal_config.nim

tests/test_wakunode.nim

tests/testlib/wakunode.nim

SionoiS

LGTM!

tests/wakunode2/test_app.nim

jm-clius

Approving to not be a bottleneck here and the general idea makes sense. The important thing is to get approving reviews from the reviewers that left some comments by re-requesting reviews once you've addressed their concerns. You could also mark specific comments as "resolved" as you go along.

…2030)

* chore: add retention policy with GB or MB limitation #1885 * chore: add retention policy with GB or MB limitation * chore: updated code post review- retention policy * ci: extract discordNotify to separate file Signed-off-by: Jakub Sokołowski <jakub@status.im> * ci: push images to new wakuorg/nwaku repo Signed-off-by: Jakub Sokołowski <jakub@status.im> * ci: enforce default Docker image tags strictly Signed-off-by: Jakub Sokołowski <jakub@status.im> * ci: push GIT_REF if it looks like a version Signed-off-by: Jakub Sokołowski <jakub@status.im> * fix: update wakuv2 fleet DNS discovery enrtree https://github.com/status-im/infra-misc/issues/171 * chore: resolving DNS IP and publishing it when no extIp is provided (#2030) * feat(coverage): Add simple coverage (#2067) * Add test aggregator to all directories. * Implement coverage script. * fix(ci): fix name of discord notify method Also use absolute path to load Groovy script. Signed-off-by: Jakub Sokołowski <jakub@status.im> * chore(networkmonitor): refactor setConnectedPeersMetrics, make it partially concurrent, add version (#2080) * chore(networkmonitor): refactor setConnectedPeersMetrics, make it partially concurrent, add version * add more metrics, refactor how most metrics are calculated * rework metrics table fillup * reset connErr to make sure we honour successful reconnection * chore(cbindings): Adding cpp example that integrates the 'libwaku' (#2079) * Adding cpp example that integrates the `libwaku` --------- Co-authored-by: NagyZoltanPeter <113987313+NagyZoltanPeter@users.noreply.github.com> * fix(ci): update the dependency list in pre-release WF (#2088) * chore: adding NetConfig test suite (#2091) --------- Signed-off-by: Jakub Sokołowski <jakub@status.im> Co-authored-by: Jakub Sokołowski <jakub@status.im> Co-authored-by: Anton Iakimov <yakimant@gmail.com> Co-authored-by: gabrielmer <101006718+gabrielmer@users.noreply.github.com> Co-authored-by: Álex Cabeza Romero <alex93cabeza@gmail.com> Co-authored-by: Vaclav Pavlin <vaclav@status.im> Co-authored-by: Ivan Folgueira Bande <128452529+Ivansete-status@users.noreply.github.com> Co-authored-by: NagyZoltanPeter <113987313+NagyZoltanPeter@users.noreply.github.com>

vpavlin reviewed Sep 14, 2023

View reviewed changes

apps/wakunode2/internal_config.nim Show resolved Hide resolved

gabrielmer self-assigned this Sep 15, 2023

gabrielmer force-pushed the fixing-enr-ip-with-dns-enabled branch from 70fdb01 to 2b225c6 Compare September 19, 2023 12:05