chore: deterministic message hash algorithm updated #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABresting
requested review from
richard-ramos,
SionoiS,
jm-clius and
Ivansete-status
|
You can find the image built from this PR at Built from 2381964 |
3 tasks
SionoiS
approved these changes
Nov 21, 2023
jm-clius
approved these changes
Nov 22, 2023
waku/waku_core/message/digest.nim
Outdated
| @@ -22,6 +22,15 @@ type WakuMessageDigest* = array[32, byte] | |||
| converter toBytesArray*(digest: MDigest[256]): WakuMessageDigest = | |||
| digest.data | |||
|
|
|||
| converter toBytesFromInt64*(num: int64): seq[byte] = | |||
There was a problem hiding this comment.
I think there is already a utility module to achieve this:
There was a problem hiding this comment.
Thanks Hanno, nice catch! Integrating the new change.
jm-clius
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in RFC related change, the deterministic message hash algorithm is updated. Waku message
timestampis added to the hash/digest computation.Changes
Issue
closes #2215