Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vendor dependencies for release 0.24.0 #2329

Closed
31 of 33 tasks
Ivansete-status opened this issue Jan 2, 2024 · 3 comments · Fixed by #2333
Closed
31 of 33 tasks

Bump vendor dependencies for release 0.24.0 #2329

Ivansete-status opened this issue Jan 2, 2024 · 3 comments · Fixed by #2333
Assignees
Labels
dependencies Pull requests that update a dependency file or issues that track it

Comments

@Ivansete-status
Copy link
Collaborator

Ivansete-status commented Jan 2, 2024

Update nwaku "vendor" dependencies.

Items to bump

  • dnsclient.nim ( update to the latest tag version )
  • nim-bearssl
  • nimbus-build-system
  • nim-chronicles
  • nim-chronos
  • nim-confutils
  • nimcrypto
  • nim-dnsdisc
  • nim-eth
  • nim-faststreams
  • nim-http-utils
  • nim-json-rpc
  • nim-json-serialization
  • nim-libbacktrace
  • nim-libp2p ( update to the unstable branch )
  • nim-metrics
  • nim-nat-traversal
  • nim-presto
  • nim-regex ( update to the latest tag version )
  • nim-secp256k1
  • nim-serialization
  • nim-sqlite3-abi ( update to the latest tag version )
  • nim-stew
  • nim-stint
  • nim-taskpools
  • nim-testutils
  • nim-toml-serialization
  • nim-unicodedb
  • nim-unittest2
  • nim-web3
  • nim-websock
  • nim-zlib
  • zerokit ( this should be kept in version v0.3.4 )
@Ivansete-status Ivansete-status added the dependencies Pull requests that update a dependency file or issues that track it label Jan 2, 2024
@Ivansete-status Ivansete-status self-assigned this Jan 2, 2024
@Ivansete-status
Copy link
Collaborator Author

We cannot bump the nim-toml-serialization because it changes the way an array attribute is parsed.

We use that when parsing a config file, i.e. ./build/wakunode2 --config-file=cfg_node.txt.
The array attributes now need a comma. For example, the following attribute from within the config file:

pubsub-topic = [ "/waku/2/default-waku/proto" "/waku/2/testing-store" ]

... should be converted to:

pubsub-topic = [ "/waku/2/default-waku/proto", "/waku/2/testing-store" ]

and this is quite a big breaking change.

See the changes introduced:
https://github.com/status-im/nim-toml-serialization/compare/43c546c365af4d291c33b7d94b5b730300165aaf..master

@Ivansete-status
Copy link
Collaborator Author

The nim-web3 dependency is not updated either because it caused too big changes in our code base (tests failed)
We will revisit this bump again. There is no need to bump it unless we need the RLN codebase to enjoy from new features implemented.
Thanks @rymnc for the advise!

@Ivansete-status
Copy link
Collaborator Author

Weekly Update

  • achieved: bump dependencies to prepare the v0.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file or issues that track it
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant