chore: bump vendors for 0.24.0 #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vendors have changes but are not being updated for the reason explained. nim-web3: not updated because unit tests started to fail and no straightforward solution found. nim-toml-serialization: not updated because it introduced a breaking change on how the --config-file attribute is parsed. The array attributes now need a comma. For example, the following attribute from within the config file: pubsub-topic = [ "/waku/2/default-waku/proto" "/waku/2/testing-store" ] ... should be converted to: pubsub-topic = [ "/waku/2/default-waku/proto", "/waku/2/testing-store" ] and we cannot accept that breaking change
|
You can find the image built from this PR at Built from 7c7b8e5 |
Ivansete-status
requested review from
NagyZoltanPeter,
SionoiS,
gabrielmer and
jm-clius
gabrielmer
approved these changes
Jan 4, 2024
NagyZoltanPeter
approved these changes
Jan 4, 2024
SionoiS
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following vendors have changes but are not being updated for the reason explained.
nim-web3: not updated because unit tests started to fail and no straightforward solution found.
nim-toml-serialization: not updated because it introduced a breaking change on how the --config-file attribute is parsed. The array attributes now need a comma. For example, the following attribute from within the config file:
pubsub-topic = [ "/waku/2/default-waku/proto" "/waku/2/testing-store" ]
... should be converted to:
pubsub-topic = [ "/waku/2/default-waku/proto", "/waku/2/testing-store" ]
and we cannot accept that breaking change
Issue
closes #2329