chore: improve POST /relay/v1/auto/messages/{topic} error handling #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 989d5d8 |
gabrielmer
force-pushed
the
chore-improve-rest-api-error-handling-2
branch
from
45a3566
to
365ffbb
Compare
gabrielmer
requested review from
SionoiS,
Ivansete-status and
NagyZoltanPeter
NagyZoltanPeter
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling the endpoint
POST /relay/v1/auto/messages/{topic}with an invalid content topic, the API response was 200 OK even though it had failed internally in the node.Added error handling so a proper status code and message get returned.
Changes
publish()fromvoidtoFuture[Result[void, string]]for subsequent error checkingPOST /relay/v1/auto/messages/{topic}endpointpublish()in the codebase to comply with the new function signatureIssue
closes #2190