Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(noise): T_ss should be ss not se #1432

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix(noise): T_ss should be ss not se #1432

merged 1 commit into from
Nov 29, 2022

Conversation

s1fr0
Copy link
Contributor

@s1fr0 s1fr0 commented Nov 28, 2022

This PR fixes a bug in the definition of the T_ss type in Noise module, that should be equal to the string ss and not se.

A great catch from @richard-ramos !

@s1fr0 s1fr0 added the track:conversational-security Conversational security track (Secure Messaging) label Nov 28, 2022
@s1fr0 s1fr0 self-assigned this Nov 28, 2022
@status-im-auto
Copy link
Collaborator

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 84db508 #1 2022-11-28 23:09:04 ~21 min macos 📦bin

rymnc
rymnc approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1fr0 s1fr0 merged commit bcab369 into master Nov 29, 2022
@s1fr0 s1fr0 deleted the fix-noise branch November 29, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos

Assignees

@s1fr0 s1fr0

Labels
track:conversational-security Conversational security track (Secure Messaging)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s1fr0 @status-im-auto @rymnc