Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): set store rpc codec pagesize type to uint64 #1520

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix(store): set store rpc codec pagesize type to uint64 #1520

merged 1 commit into from
Jan 31, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Jan 30, 2023

This regression was introduced during the Waku archive and the Waku store code split.

This PR potentially resolves issue #1514

@LNSD LNSD self-assigned this Jan 30, 2023
@LNSD LNSD mentioned this pull request Jan 30, 2023
Closed
@status-im-auto
Copy link
Collaborator

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ba533bf #1 2023-01-30 23:04:59 ~17 min macos 📦bin

@LNSD LNSD merged commit 77c6404 into master Jan 31, 2023
@LNSD LNSD deleted the fix-store-issue-1514 branch January 31, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@jm-clius jm-clius jm-clius approved these changes

@fryorcraken fryorcraken Awaiting requested review from fryorcraken

Assignees

@LNSD LNSD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LNSD @status-im-auto @richard-ramos @jm-clius