-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): push images to new wakuorg/nwaku repo #2077
Conversation
You can find the image built from this PR at
Built from 1bb258f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @jakubgs.
@vpavlin @Ivansete-status @chair28980 Important to coordinate with everyone affected by this change, i.e. mention in the next release notes, make sure other documentation in waku.org is updated and that affected parties (especially Dappnode package: https://github.com/rndlabs/dappnodepackage-nwaku/blob/ee3f5e79cea9d154a82e4d3f6bb0b90b440de23d/nwaku/Dockerfile#L3C1-L3C1) is informed.
thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for it! I added a little nitpick.
Cheers
Signed-off-by: Jakub Sokołowski <jakub@status.im>
b6f0574
to
b404336
Compare
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
9b22476
to
dbd5b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the image tags!
pre-approving assuming the requested change is gonna be made before merge:)
dbd5b6d
to
184479e
Compare
Related to: waku-org/nwaku#2077 Signed-off-by: Jakub Sokołowski <jakub@status.im>
This was integrated. |
And other changes that make sense in the context.