Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): push images to new wakuorg/nwaku repo #2077

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Sep 26, 2023

And other changes that make sense in the context.

@jakubgs jakubgs added the infra Infra, devops, CI and related tasks label Sep 26, 2023
@jakubgs jakubgs self-assigned this Sep 26, 2023
@waku-org waku-org deleted a comment from github-actions bot Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2077

Built from 1bb258f

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @jakubgs.

@vpavlin @Ivansete-status @chair28980 Important to coordinate with everyone affected by this change, i.e. mention in the next release notes, make sure other documentation in waku.org is updated and that affected parties (especially Dappnode package: https://github.com/rndlabs/dappnodepackage-nwaku/blob/ee3f5e79cea9d154a82e4d3f6bb0b90b440de23d/nwaku/Dockerfile#L3C1-L3C1) is informed.

@alrevuelta
Copy link
Contributor

thanks!
@jm-clius review pending, but this should be it: rndlabs/dappnodepackage-nwaku#23

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! I added a little nitpick.
Cheers

docs/operators/how-to/run-with-rln.md Outdated Show resolved Hide resolved
@vpavlin vpavlin added the release-notes Issue/PR needs to be evaluated for inclusion in release notes highlights or upgrade instructions label Sep 27, 2023
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@waku-org waku-org deleted a comment from github-actions bot Sep 27, 2023
@vpavlin vpavlin changed the title ci: push images to new wakuorg/nwaku repo chore(ci): push images to new wakuorg/nwaku repo Sep 27, 2023
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the image tags!

pre-approving assuming the requested change is gonna be made before merge:)

@jakubgs jakubgs merged commit 184479e into master Sep 27, 2023
9 of 10 checks passed
@jakubgs jakubgs deleted the ci/push-docker-to-wakuorg branch September 27, 2023 09:52
jakubgs added a commit to status-im/infra-role-nim-waku that referenced this pull request Sep 27, 2023
Related to:
waku-org/nwaku#2077

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@mfw78
Copy link

mfw78 commented Sep 30, 2023

thanks! @jm-clius review pending, but this should be it: rndlabs/dappnodepackage-nwaku#23

This was integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra, devops, CI and related tasks release-notes Issue/PR needs to be evaluated for inclusion in release notes highlights or upgrade instructions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants